[RPC][wallet] Add rescanblockchain RPC command functionality
#2240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…canned block or nullptr if scan went well.
Fuzzbawls
requested changes
Mar 10, 2021
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
some initial styling changes left. also, prefer to have a blank line before the Arguments:, Result:, and Examples: sections for readability.
Adaptation of btc@c77170fbdbdfcd2ba830a1755450a2e5469f4e35
adaptation of btc@75a08e7d17da9db2ac0e9f55a4286dda912385bc
furszy
force-pushed
the
2020_rescanchain
branch
from
1ef181b to
896520e
Compare
Author
|
updated per feedback, removed the quotes around numeric arguments. |
1 task
random-zebra
approved these changes
Mar 30, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
ACK 896520e
This needs a bit more work to be usable from the GUI console, due to the cs_main lock, which is held for the whole duration (essentially we need to get to bitcoin#11281... the rabbit hole starts with #2277).
Other than that, this works as intended from a headless node.
Fuzzbawls
approved these changes
Apr 4, 2021
Fuzzbawls
added
the
Needs Release Notes
furszy
added a commit
that referenced
this pull request
Apr 6, 2021
7e0c709 Clean up importmulti help text (Fuzzbawls) 1cacda6 [Tests] Fix and Re-enable wallet_importmulti.py (random-zebra) 4ff0b4a [Trivial] NULL --> nullptr in skiplist_tests (random-zebra) b53a986 Add unit test for FindEarliestAtLeast (Suhas Daftuar) d1bb973 [RPC] Add importmulti call (random-zebra) Pull request description: Based on top of: - [x] #2240 Essentially backport bitcoin#7551 and bitcoin#9490, with more recent changes to adapt to the current sources. Fix and re-enable the `wallet_importmulti.py` functional test. ACKs for top commit: Fuzzbawls: ACK 7e0c709 furszy: ACK 7e0c709 and merging.. Tree-SHA512: 47a4452bfaeae16d09268d3eaa0c1a5d94a39accf86b7345818f8436222650515a8bf66ef331ba478058aabcbcfcf978192f39b349027e189b7ac41cd3e69a6e
random-zebra
added a commit
that referenced
this pull request
Apr 14, 2021
…fication fix f2734f0 [Tests] Fix policyestimator and validation_block tests (random-zebra) 3448bc8 wallet: Minimal fix to restore conflicted transaction notifications (Antoine Riard) ba9d84d feature_notifications.py mimic upstream is_wallet_compiled() function to make future back ports easier. (furszy) 37c9944 [mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks (John Newbery) 5cc619f [validation] Remove pool member from ConnectTrace (John Newbery) 1e453b7 [validation] Remove NotifyEntryRemoved callback from ConnectTrace (John Newbery) e774bfd [validation] Remove conflictedTxs from PerBlockConnectTrace (John Newbery) 389680a [validation interface] Remove vtxConflicted from BlockConnected (furszy) 19c9383 [wallet] Notify conflicted transactions in TransactionRemovedFromMempool (John Newbery) 139882d Fire TransactionRemovedFromMempool from mempool This commit fires TransactionRemovedFromMempool callbacks from the mempool and cleans up a bunch of code. (furszy) Pull request description: PR built on top of #2209, #2235 and #2240 (don't get scared by the amount of commits, most of them are coming from 2209. Will disappear as soon as that one gets merged). Based on the brief talk originated in #2209 (comment) . Solving the conflicted transactions external listeners notification. Adapting the following PRs: bitcoin#14384, bitcoin#17477 and bitcoin#18982. Without functional test support, for the time being, for the lack of RBF functionality. ACKs for top commit: Fuzzbawls: ACK f2734f0 random-zebra: re-utACK f2734f0 and merging... Tree-SHA512: 07d437e0d5e5d9798b16d982b6f58585d1f0dcd82251c5ac06f47e44233433831243d451ce43068e33c6002a64b76fa4d165167a2cbaeeedc28cde2019853565
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following changes:
rescanblockchainRPC command with two argumentsstart_heightend_heightto trigger a chain rescan at any time during runtime + test case (adaptation of docs(rpc): introduce more RPC help text and deduplicate governance RPC logic to resolve pending definitions dashpay/dash#7061).abortrescanRPC command to stop any long running rescan if needed at runtime (this is helpful for example in case of importing a private/sapling key that if the user is not aware of the extra "scan" boolean argument, it will rescan the complete chain). Coming from [wallet] Rescan abortability bitcoin/bitcoin#10208.