Skip to content

Conversation

@Fuzzbawls
Copy link
Collaborator

Coming from bitcoin#11017

This PR intends to plug some leaks. It specifically implements adherence to the requirement in BDB to close a handle which failed to open (https://docs.oracle.com/cd/E17276_01/html/api_reference/C/dbopen.html):

The DB->open() method returns a non-zero error value on failure and 0 on success. If DB->open() fails, the DB->close() method
must be called to discard the DB handle.

@Fuzzbawls Fuzzbawls added this to the 5.1.0 milestone Feb 7, 2021
@Fuzzbawls Fuzzbawls self-assigned this Feb 7, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0c4b20f

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0c4b20f

@furszy furszy merged commit d3afb33 into PIVX-Project:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants