[Bug][Refactoring] Miscellaneous fixes #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202102_misc-fixes-coverity
branch
3 times, most recently
from
b6c573e to
e51b723
Compare
Author
|
Rebased. |
random-zebra
force-pushed
the
202102_misc-fixes-coverity
branch
from
6bd4f63 to
2e7d905
Compare
Author
|
Rebased. |
mapInvalidOutPoints and mapInvalidSerials are only written, never read. AddInvalidSpendsToMap is also buggy, as it keeps a pointer to a local variable after it goes out of scope.
Partially reverting PIVX-Project#494
random-zebra
force-pushed
the
202102_misc-fixes-coverity
branch
from
2e7d905 to
84b4185
Compare
furszy
approved these changes
Feb 14, 2021
Fuzzbawls
approved these changes
Feb 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of small fixes for the following issues/defects (discovered with the coverity tool):
sizeofargument (tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt bitcoin/bitcoin#11024 + revert [Bug] remove use of variable length buffer #494)