Github-Pull: bitcoin#2112
Rebased-From: 2e53e4c

…tion data

Github-Pull: bitcoin#2113
Rebased-From: 3a1b103

serialized size of std::vector (inputs, outputs, shieldspends,
shieldoutputs) takes more than one byte if the vector has more than 253
elements.
Github-Pull: bitcoin#2111
Rebased-From: 5d2e6e4

Github-Pull: bitcoin#2111
Rebased-From: 8e79aa9

Github-Pull: bitcoin#2111
Rebased-From: 0e08e40

Github-Pull: bitcoin#2111
Rebased-From: efa1331

…lt address.

Github-Pull: bitcoin#2116
Rebased-From: eb28c9f

Cold-staking contacts are only saved when sending a delegation (with
label for staker address), but they cannot be added directly in the
addresses widget.
Remove the check preventing this.
Github-Pull: bitcoin#2121
Rebased-From: 058101f

Currently the confirmation pop-up is shown only when the RPC command
string is exactly "dumpwallet"/"dumpprivkey" (with no arguments).
Such command strings are not valid, as both RPC functions require one
argument (the filename for "dumpwallet" and the PIVX address for
"dumpprivkey").

So, when the user confirms the dialog, the RPC console returns an error
(as the argument is missing), showing the RPC help.

If the user, instead, enters the correct RPC strings (`dumpwallet
<filename>`/`dumpprivkey <pivxaddress>`), then **the warning dialog is
NOT presented** and the command is executed immediately.

Fix it by doing a pre-validation for the potentially dangerous commands.
Github-Pull: bitcoin#2122
Rebased-From: 1d63d1a

Github-Pull: bitcoin#2122
Rebased-From: 81e4d15

The for loop creates the required object directly

Github-Pull: bitcoin#2119
Rebased-From: ba9a699

Github-Pull: bitcoin#2119
Rebased-From: 6f8f460

Also drop the "ed" suffix from return error messages in these two
commands.

Github-Pull: bitcoin#2119
Rebased-From: c15c5c6

Github-Pull: bitcoin#2119
Rebased-From: f83331d

Github-Pull: bitcoin#2119
Rebased-From: 84367ea

`initial_block_downloading` isn't a member of the `shield_pool_value`
object.

Github-Pull: bitcoin#2119
Rebased-From: b5404b5

Github-Pull: bitcoin#2119
Rebased-From: 3fc72f4

Github-Pull: bitcoin#2119
Rebased-From: 795b006

…e 1kk range.

Github-Pull: bitcoin#2115
Rebased-From: 2d7f387

Github-Pull: bitcoin#2115
Rebased-From: 6f02ec4

Github-Pull: bitcoin#2120
Rebased-From: 501782a

Github-Pull: bitcoin#2120
Rebased-From: 8ec1875

Github-Pull: bitcoin#2120
Rebased-From: e14fe3d

Github-Pull: bitcoin#2120
Rebased-From: 092f825

…a diversified address different than the default one.

Github-Pull: bitcoin#2123
Rebased-From: 910b580

Noting changes since v4.3.0

Github-Pull: bitcoin#2114
Rebased-From: ba705a6

Github-Pull: bitcoin#2114
Rebased-From: 1d18ebf

Github-Pull: bitcoin#2114
Rebased-From: 39ee780

Github-Pull: bitcoin#2114
Rebased-From: 0f3f77d

Github-Pull: bitcoin#2114
Rebased-From: 08b50bb

Github-Pull: bitcoin#2114
Rebased-From: cc3c83d

Github-Pull: bitcoin#2114
Rebased-From: d36f37f

Github-Pull: bitcoin#2114
Rebased-From: c94c19e

Github-Pull: bitcoin#2114
Rebased-From: 8f9e1d9

…ommendation.

Github-Pull: bitcoin#2114
Rebased-From: e90cbe6

Github-Pull: bitcoin#2114
Rebased-From: d88e6d8