Skip to content

Conversation

@random-zebra
Copy link

Two minor issues addressed here:

  • the expected size is 2 bytes off if there are more than 253 inputs and/or outputs (compact size), thus the "after fee" label returns an amount slightly bigger, and the transaction creation fails when copy-pasting it.
  • the fDust label is not being updated properly for shield recipient. The fDust tooltip reports an invalid, hardcoded, dust threshold.

serialized size of std::vector (inputs, outputs, shieldspends,
shieldoutputs) takes more than one byte if the vector has more than 253
elements.
furszy
furszy previously approved these changes Dec 28, 2020
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, code review utACK 0e08e40

@random-zebra random-zebra added this to the 5.0.0 milestone Dec 28, 2020
@random-zebra random-zebra added the Needs Backport Placeholder tag for anything needing a backport to prior version branches label Dec 30, 2020
@random-zebra
Copy link
Author

Added a commit to return a struct with getTotals(), as suggested by @furszy

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, utACK efa1331

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK efa1331

@furszy furszy merged commit e217d1e into PIVX-Project:master Dec 31, 2020
furszy referenced this pull request in furszy/bitcoin-core Jan 5, 2021
serialized size of std::vector (inputs, outputs, shieldspends,
shieldoutputs) takes more than one byte if the vector has more than 253
elements.
Github-Pull: bitcoin#2111
Rebased-From: 5d2e6e4
furszy referenced this pull request in furszy/bitcoin-core Jan 5, 2021
furszy referenced this pull request in furszy/bitcoin-core Jan 5, 2021
furszy referenced this pull request in furszy/bitcoin-core Jan 5, 2021
Fuzzbawls added a commit that referenced this pull request Jan 6, 2021
41fb982 Add PR list and authors to release notes for v5.0.0 (Fuzzbawls)
528912b [Doc] release-notes: final enforcement block height plus timeline recommendation. (furszy)
a778833 [Doc] Add "Mandatory Upgrade" section (ActiveProtocol upgrade time TBD) Github-Pull: #2114 Rebased-From: 8f9e1d9 (random-zebra)
0c2dc8d [Doc] Document HD wallet upgrade to SAPLING_VERSION Github-Pull: #2114 Rebased-From: c94c19e (random-zebra)
ff59122 [Doc] Document SwiftX and Zerocoin removal Github-Pull: #2114 Rebased-From: d36f37f (random-zebra)
0e37c67 [Doc] Document consensus and policy changes related to Shield Github-Pull: #2114 Rebased-From: cc3c83d (random-zebra)
07d9db7 [Doc] Document more RPC changes Github-Pull: #2114 Rebased-From: 08b50bb (random-zebra)
95992ac [Doc] minor changes to the "Shield Protocol" section of the relnotes Github-Pull: #2114 Rebased-From: 0f3f77d (random-zebra)
75a7597 [Doc] Document new dependencies (sodium/rust) Github-Pull: #2114 Rebased-From: 39ee780 (random-zebra)
033e8b3 [Doc] Document sapling parameters for installation/upgrade Github-Pull: #2114 Rebased-From: 1d18ebf (random-zebra)
a3d2b52 Add RPC changes to the release notes (Fuzzbawls)
b2b113c [Doc] v5 release notes (furszy)
3fd22bf [GUI] Update Translations from Transifex (Fuzzbawls)
78d0b01 Test case: StoreAndLoadSaplingZkeys, added a loop to try to generate a diversified address different than the default one. (furszy)
090b901 [RPC][Wallet] Update also Sapling HD seed with sethdseed Github-Pull: #2120 Rebased-From: 092f825 (random-zebra)
36336ec [Tests] Verify Sapling wallet HD chain in wallet_hd.py Github-Pull: #2120 Rebased-From: e14fe3d (random-zebra)
d8d347e [RPC] Add shield address support to getaddressinfo Github-Pull: #2120 Rebased-From: 8ec1875 (random-zebra)
9eb84ce [Cleanup][RPC] Remove not-returned fields from getaddressinfo help Github-Pull: #2120 Rebased-From: 501782a (random-zebra)
0d8b6c0 Cleaning up not used `nWalletDBUpdated`. (furszy)
6219dfe [GUI] fixing tooltip balance amount cropped when the value surpass the 1kk range. (furszy)
0e158b0 RPC: Document the `services` return entry in `getinfo` (Fuzzbawls)
576efe8 RPC: Properly document all example return fields in getchaintips (Fuzzbawls)
7100c33 RPC: Fix help output for getblockchaininfo (Fuzzbawls)
3254dc8 RPC: Fix help output for waitfor* commands (Fuzzbawls)
46f47c5 RPC: document results for dumpwallet (Fuzzbawls)
3bfb513 RPC: drop "ed" suffix from input arguments for shield export commands (Fuzzbawls)
9bc65af RPC: document per-network MN count for getmasternodecount (Fuzzbawls)
aaf9216 RPC: Remove unused mnEntries vector (Fuzzbawls)
90b1d6e [GUI][RPC] Add exportsaplingkey to the list of pot. dangerous cmds Github-Pull: #2122 Rebased-From: 81e4d15 (random-zebra)
55ff95e [GUI][BUG] Fix confirmation dialog for dumpwallet/dumpprivkey (random-zebra)
8863d76 [GUI][Trivial] Save cold-staking address in contacts (random-zebra)
51e1c97 Test: print error if shield diversified address is equal to the default address. (furszy)
351b2ce [Refactor] CoinControl: getTotals returns struct Github-Pull: #2111 Rebased-From: efa1331 (random-zebra)
6506d71 [BUG] Fix isDust label in coincontrol Github-Pull: #2111 Rebased-From: 0e08e40 (random-zebra)
805552c [Refactor] CControl: decouple getTotals from updateLabels Github-Pull: #2111 Rebased-From: 8e79aa9 (random-zebra)
391eff6 [GUI] Fix size computation in coin-control (random-zebra)
1656246 [Doc] RPC getrawtransaction and decoderawtransaction, sapling transaction data (furszy)
1ed9970 Set v5 enforcement time for mainnet (furszy)
0cf5703 [GUI] Support for proposal outputs (op_return). (furszy)

Pull request description:

  Back porting PRs from master:

  #2100
  #2111
  #2112
  #2113
  #2114
  #2115
  #2116
  #2119
  #2120
  #2121
  #2122
  #2123
  #2125

ACKs for top commit:
  random-zebra:
    utACK 41fb982
  Fuzzbawls:
    ACK 41fb982

Tree-SHA512: da8706da289ea7f0b09fc6fa39bd55579d25cb6b0761ac9999ccf6609cd68fe54bd5b325d9c686758b78b234397eb1e1d0091e69f663110f695899f8fa7c3c7a
@random-zebra random-zebra removed the Needs Backport Placeholder tag for anything needing a backport to prior version branches label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants