[Build] Don't compile PoW mining RPC commands by default #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
changed the title
Fuzzbawls
force-pushed
the
2020_rpc-no-compile-mining-commands
branch
from
6fb62fd to
624fdff
Compare
Fuzzbawls
changed the title
random-zebra
previously approved these changes
Jan 22, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
ACK 624fdff09d7da6138d32b98fe4c32d15728aa157.
Maybe it's worth to document this new configure flag --enable-mining-rpc in the build-* notes, or somewhere else (at least in the release notes).
random-zebra
added
the
Needs Release Notes
This adds a configure flag to skip compiling the PoW-related mining RPC commands, which aren't ever used outside of the initial PoW phase. The `generate` command is retained for regtest compatibility.
Fuzzbawls
force-pushed
the
2020_rpc-no-compile-mining-commands
branch
from
624fdff to
1a5d903
Compare
Fuzzbawls
removed
the
Needs Release Notes
Collaborator
Author
|
rebased and added a note in the release notes template. Not going to add anything to the |
furszy
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configure flag to skip compiling the PoW-related mining RPC
commands, which aren't ever used outside of the initial PoW phase.
The
generatecommand is retained for regtest compatibility.