Skip to content

[P2P] Add missing lock in CAddrMan::Clear() #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
random-zebra merged 1 commit into from
Dec 5, 2020
Merged

[P2P] Add missing lock in CAddrMan::Clear() #2028

random-zebra merged 1 commit into from
Dec 5, 2020

Conversation

@random-zebra
Copy link

@random-zebra random-zebra commented Dec 5, 2020

Straightforward cherry-pick from bitcoin#11585

@practicalswift @random-zebra
addrman: Add missing lock in Clear() (CAddrMan)
87e33eb 
The variable vRandom is guarded by the mutex cs.
@random-zebra random-zebra added this to the 5.0.0 milestone Dec 5, 2020
@random-zebra random-zebra self-assigned this Dec 5, 2020
furszy
furszy approved these changes Dec 5, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 87e33eb

Fuzzbawls
Fuzzbawls approved these changes Dec 5, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 87e33eb

@random-zebra random-zebra merged commit 007359a into PIVX-Project:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@furszy furszy furszy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@random-zebra random-zebra

Labels

P2P Upstream

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@random-zebra @furszy @Fuzzbawls @practicalswift