[Wallet] HD wallets automatic upgrade to sapling features. #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_wallet_auto_upgrade_sapling
branch
from
c3a0a03 to
0318af4
Compare
Author
|
Added a second commit covering locked wallets that require a visual upgrade flow (unlocking the wallet in the process) and the startup reminder dialog. |
…FEATURE_SAPLING. Only the seed is needed to generate the sapling keys tree. Plus guarding generate shielded address method, so pre-HD wallets show the proper error when they cannot generate shielded addresses.
furszy
force-pushed
the
2020_wallet_auto_upgrade_sapling
branch
from
0318af4 to
22a5f4f
Compare
Author
|
Updated solving GA issue, ready to be merged. |
Fuzzbawls
approved these changes
Dec 5, 2020
Fuzzbawls
added
the
Needs Release Notes
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HD wallets (
FEATURE_PRE_SPLIT_KEYPOOL) automatic upgrade toFEATURE_SAPLINGto support shielded functionality by default.This is an straightforward version bump because only the seed is needed to generate the sapling keys tree. More info in #1553.
Plus added a version guard in the shielded addresses generation method, so pre-HD wallets show the proper error when they cannot generate shielded addresses (essentially, will notify the user that he/she needs to upgrade their wallet to support shielded operations).
As an extra information, pre-HD wallets who upgrade to HD running v5, will automatically be upgraded to support sapling features. This was done in #1553 as well.