[BUG] Fix transaction size limits for sapling version #1956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid failures due to dust outputs
random-zebra
force-pushed
the
202011_tx-size-limit
branch
from
94689b3 to
c004841
Compare
Author
|
Rebased. |
furszy
previously approved these changes
Nov 10, 2020
random-zebra
force-pushed
the
202011_tx-size-limit
branch
from
446bbb7 to
c1558b5
Compare
random-zebra
force-pushed
the
202011_tx-size-limit
branch
from
c1558b5 to
3f80e84
Compare
furszy
approved these changes
Nov 10, 2020
Fuzzbawls
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size limits for a sapling transaction are currently checked in 3 places:
1-
CheckTransaction(validation.cpp)2-
CheckTransactionWithoutProofVerification(called bySaplingValidation::CheckTransaction)3-
SaplingValidation::ContextualCheckTransactionWhile in (2) and (3) the size is correctly checked against
MAX_TX_SIZE_AFTER_SAPLING, in (1) it is checked against the oldMAX_ZEROCOIN_TX_SIZE.So a shielded transaction with size greater than
MAX_ZEROCOIN_TX_SIZEwould be wrongly rejected inCheckTransaction.Fix the check in (1), selecting the correct max size for shielded/non-shielded transactions.
Move the size-check before calling SaplingValidation::CheckTransaction (as it's faster).
Remove the checks in (2) and (3) that are just redundant.
Based on top of: