[Wallet][DB] Back ports up to the CWallet/CWalletDB/CDB refactor. #1943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_wallet_db_upgrades
branch
from
3e06b3d to
46e1f3a
Compare
Author
|
This is ready to go. Update: rebased on master. |
furszy
force-pushed
the
2020_wallet_db_upgrades
branch
from
46e1f3a to
5045acd
Compare
Analogous to c++11 vector data().
Quite sure that we haven't supported MSVC 6.0 for ages (MSC_VER 1300 is >= MSVC++ 7.0) but with the C++11 switch we can be sure.
Check for EOF before every getline, and warn when reading gets to EOF before the end of the data. Stricter error checking could shed more light on issues such as bitcoin#7463 and bitcoin#7379.
Try to hide CDB/bitdb behinde CWalletDB. Prepare for full wallet database abstraction. An adapted version of btc@7184e25c80aa8b1629a700bb7a7e290ad0bb2792
Focused on the ThreadFlushWalletDB/PeriodicFlush area. An adapted version of btc@7184e25c80aa8b1629a700bb7a7e290ad0bb2792
furszy
force-pushed
the
2020_wallet_db_upgrades
branch
from
5045acd to
58504c2
Compare
Author
|
rebased on top of master. |
random-zebra
added a commit
that referenced
this pull request
Nov 12, 2020
c369cb8 Remove more unused boost includes (Fuzzbawls) ab674a0 Remove useless threadGroup parameter from Discover (Fuzzbawls) 2e82dbd Drop boost threads for upnp (Fuzzbawls) 3d96079 Drop boost threads for [alert|blocksize|wallet]notify (Fuzzbawls) c01468a Drop boost threads for torcontrol (Fuzzbawls) 27bc007 Remove unused boost includes from util.cpp (Fuzzbawls) 4bc6cee Make fs::path::string() always return utf-8 string on Windows (Fuzzbawls) b371321 utils: run commands using utf-8 string on Windows (Fuzzbawls) 19f3ee9 Avoid boost dynamic_bitset in rest_getutxos (Fuzzbawls) 1bda012 Remove un-necessary boost includes from sapling_rpc_wallet_tests.cpp (Fuzzbawls) e8b9947 Use std::function instead of boost::function in txdb (Fuzzbawls) cf83a73 Remove the Boost case_conv.hpp dependency (Fuzzbawls) 5928d40 Add custom tolower/toupper functions (Fuzzbawls) 2f8b7a1 Implement ParseNetwork unit test (Fuzzbawls) c078e1d Remove unused Boost iostreams dependencies (Fuzzbawls) 13eb566 Use c++11 std::unique_ptr instead of boost::shared_ptr (Fuzzbawls) 27c4a8e Remove Boost dependency (static_assert.hpp) (Fuzzbawls) 6c4b4c1 Remove unused Boost dependency (version.hpp) (Fuzzbawls) 223a0a6 Remove unused boost dependency posix_time_types.hpp (Fuzzbawls) e2cf078 Remove two unused boost dependencies (Fuzzbawls) 66fabf9 Remove Boost predicate.hpp dependency (Fuzzbawls) Pull request description: This removes the dependency on Boost for a number of things that either have a direct c++11 equivalent, or could have a custom function dropped in with minimal effort. Also removes a number of unused boost header includes. I didn't replace Boost's `scoped_ptr` with c++11's `scoped_ptr` as that is already being done in #1943. I also decided to not replace `boost::assign::[map_]list_of` here as its more invasive and better suited for it's own PR. ACKs for top commit: furszy: code reviewed, utACK c369cb8 . random-zebra: utACK c369cb8 and merging... Tree-SHA512: 48508868b4760277a0f6f2477e826a4b6a4654bd2e11e322056476cd5869ad8190ce4518a00435e982ef6ad06fe8a9795ab4bcbb5107fa8c947ed92e2c0f48ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the wallet, wallet db and db wrapper areas with several back ports and updates adaptations.
List of PRs:
Note:
Low priority PR, can be reviewing after merge Sapling and tier two PRs.
I made it because we are pretty far from upstream in the db area and want to introduce some new functionality in the future that requires a more up-to-date db layer.