[RPC] Speeding up listmasternodes command #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons and totally unnecessary extra vector load. As this function is only used in listmasternodes RPC command, the checks are redundant, the MN thread only should check and update `vMasternodes`, removing any invalid masternode.
…n the mnnodeman. listmasternodes first calls GetMasternodeRanks, which loops over the MN list, then was calling `mnodeman.Find` which loops again over the MN list for absolutely no reason.
furszy
force-pushed
the
2020_speedup_listmasternodes
branch
from
5eb6372 to
872da91
Compare
Fuzzbawls
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1904 . PR starting on 9123d22.
listmasternodesRPC command was taking a considerable amount of time, checked the flow and discovered a lot of redundancies in the process. This PR aims to correct them.CMasternodeMan::GetMasternodeRanksis only used for an RPC call and it was checking and validating each Masternode instead of just retrieve them as it suppose to be doing (the tier two thread is the only one responsible of check and update the masternodes list).CMasternodeMan::GetMasternodeRankshad a totally unneeded second vector load. Looping over the entire masternodes list one more time after getting it.listmasternodesafter callingGetMasternodeRankswas looking for each of the retrieved masternodes one more time using the retrieved masternode vin (yes..).