[Refactor] Strip out cs_main lock for misbehaving from Masternodeman:ProcessMessage #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
furszy
changed the title
furszy
force-pushed
the
2020_strip_out_misbehaving_from_masternodeman_ProcessMessage
branch
from
ece5447 to
2e29c4c
Compare
Author
|
now that #1845 got merged, PR rebased. |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Looking good.
But I think it could be simplified by having the Process* methods return a simple integer representing the ban score, rather than the new struct ProcessResult (whose boolean res seems redundant: if the ban score is 0 we don't call Misbehaving regardless of the value of res).
Special attention needed for CTxIn::IsNull.
furszy
force-pushed
the
2020_strip_out_misbehaving_from_masternodeman_ProcessMessage
branch
from
2e29c4c to
c8717d9
Compare
Author
|
Updated per feedback. |
…aving call from its flow.
…ing call from its flow
… ProcessMessage below ProcessGetMNList.
…cast hash only once.
furszy
force-pushed
the
2020_strip_out_misbehaving_from_masternodeman_ProcessMessage
branch
from
c8717d9 to
50e156f
Compare
Author
|
rebased on master. |
Fuzzbawls
approved these changes
Nov 3, 2020
furszy
deleted the
2020_strip_out_misbehaving_from_masternodeman_ProcessMessage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1845.
Refactored
Masternodeman:ProcessMessagedecoupling in different methods and stripped out everycs_mainlock for aMisbehavingfunction call.