[BUG] Set budget best height before reading budget DB during init #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise all proposals/budgets are removed by `CheckAndRemove` (negative confirmations for collateral txes). Introduced in PIVX-Project#1826
random-zebra
added
Bug
Budget/Proposal System
Startup
random-zebra
added
the
Needs Backport
Merged
2 tasks
Fuzzbawls
approved these changes
Oct 6, 2020
random-zebra
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug Introduced in #1826, which makes the node erase all proposals and finalized budgets, after reading them from the DB during startup (and thus having to ask everything again from the peers).
Cause:
The budget manager best height is set after reading the budgetdb.
As non-dry runs of
CBudgetDB::Readinclude a call toCheckAndRemove()at the end (to delete expired objects), the manager's best-height needs to be already set.