Skip to content

[Test] Update sighash tests for shielded transactions. #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
random-zebra merged 1 commit into from
Oct 8, 2020
Merged

[Test] Update sighash tests for shielded transactions. #1885

random-zebra merged 1 commit into from
Oct 8, 2020

Conversation

@furszy
Copy link

@furszy furszy commented Sep 29, 2020

Decoupled from #1798 d0099f50 .
Initial sighash unit test coverage for shielded transactions.

@furszy furszy self-assigned this Sep 29, 2020
@furszy furszy changed the title Update sighash tests adding shielded transactions. Update sighash tests for shielded transactions. Sep 29, 2020
@Fuzzbawls Fuzzbawls added this to the 5.0.0 milestone Oct 2, 2020
@Fuzzbawls Fuzzbawls added the Tests label Oct 2, 2020
@Fuzzbawls Fuzzbawls changed the title Update sighash tests for shielded transactions. [Test] Update sighash tests for shielded transactions. Oct 2, 2020
random-zebra
random-zebra approved these changes Oct 3, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 69db60e

Fuzzbawls
Fuzzbawls approved these changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 69db60e

@random-zebra random-zebra merged commit 40278cb into PIVX-Project:master Oct 8, 2020
@furszy furszy deleted the 2020_sighash_test_updated_to_sapling branch November 29, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

Sapling Tests Upstream ZCash

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@furszy @Fuzzbawls @random-zebra