Skip to content

Conversation

@furszy
Copy link

@furszy furszy commented Sep 27, 2020

PR solving the current master's syncing issue (syncing process not passing through block 5840), solved in 9d8b8a2.

Essentially, when we merged #1815, we moved from using the default transaction constructor and the ser/unser template methods (SerializationOp) to be using, inside the templated serialization puzzle, the deserializing constructor (CTransaction(deserialize_type, Stream& s)) which internally creates a CMutableTransaction which wasn't having the same sapling tx version guard as CTransaction ser/unser method. So, in other words, it was trying to parse the shielded transaction data from an old version two transaction (yes, we already have version two transaction in our network.. first one is in block 5840).

Plus, i took the mischief of not only including the bugfix, have added:

@furszy furszy self-assigned this Sep 27, 2020
@random-zebra
Copy link

Nice one 🍺 Concept/Code ACK.

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9d8b8a2

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9d8b8a2

@furszy furszy changed the title BugFix: tx sync parsing problem fixed + some extra commits. BugFix: tx sync parsing problem fixed + extra refactoring. Sep 27, 2020
@random-zebra random-zebra merged commit 8e7fa72 into PIVX-Project:master Sep 27, 2020
@furszy furszy deleted the 2020_fix_block_parsing branch November 29, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants