Mrs Peacock in The Library with The Candlestick (killed main.{h,cpp}) #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202009_mainsplit
branch
3 times, most recently
from
2d7de4a to
80e4c05
Compare
Author
|
Rebased on master. Ready for review. |
As orphan state is now "network state", like in d6ea737, UnloadBlockIndex is only used during init if we end up reindexing to clear our block state so that we can start over. However, at that time no connections have been brought up as CConnman hasn't been started yet, so all of the network processing state logic is empty when its called.
add extern declaration for now. cs_main will be removed from here. (Also fix AcceptBlockHeader method signature).
random-zebra
force-pushed
the
202009_mainsplit
branch
from
80e4c05 to
34ad9d5
Compare
Author
|
Rebased again. |
Fuzzbawls
approved these changes
Sep 30, 2020
furszy
approved these changes
Sep 30, 2020
This was referenced Oct 1, 2020
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally split main.{h,cpp} file in net_processing.{h,cpp}/validation.{h,cpp} as per upstream (bitcoin#9260) 🎉
Built on top of