[Sapling] Incremental merkle tree backport. #1870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_incremental_merkle_tree_backport
branch
5 times, most recently
from
78159c4 to
352a720
Compare
Author
|
This is fixing #1798 travis issues. took a while to decouple it but it's is ready for review. |
Fuzzbawls
requested changes
Oct 1, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
Could use some cleanup regarding our own standards and helpers/wrappers so as to not re-introduce new boost dependencies.
furszy
force-pushed
the
2020_incremental_merkle_tree_backport
branch
from
352a720 to
626b0d9
Compare
Author
|
Done, styling updated to our sources conventions 👍 . |
Fuzzbawls
approved these changes
Oct 3, 2020
furszy
added a commit
that referenced
this pull request
Oct 3, 2020
b11b357 removing global namespace usage for noteencryption and sapling_note unit tests (furszy) 52da4e0 [Sapling] Note Encryption unit tests back ported. (furszy) 4d2f01a [Sapling] change cm() to cmu() in SaplingNote class (furszy) Pull request description: Another decoupling from #1798. Similar to #1870, these changes are part of the primitives unit test coverage back port work. Commits included: * change cm() to cmu() in SaplingNote class —> d437276a4b922c6c70d810cff0719a2e76f1a4bc * Note Encryption unit tests back ported. —> e4c1bbf1618fd797599b6bf3511cea79e6d9d4d7 ACKs for top commit: Fuzzbawls: ACK b11b357 random-zebra: re-utACK b11b357 Tree-SHA512: 56914dba65ee239f7e6713a111abca5bd1a4e684fadcdbed4314295f499f3b6689271fa7999c7f182dcba069ebe29299bed944e7ee6b1bcb3aad987884811242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is coming from #1798, focused on include the incremental merkle tree primitive with all of its unit tests.
This base primitive class is almost one to one with upstream.
Decoupled the following commits: