Skip to content

[wallet] GetMasternodeVinAndKeys wasn't locking cs_wallet to obtain the collateral. #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furszy merged 1 commit into from
Oct 1, 2020
Merged

[wallet] GetMasternodeVinAndKeys wasn't locking cs_wallet to obtain the collateral. #1868

furszy merged 1 commit into from
Oct 1, 2020

Conversation

@furszy
Copy link

@furszy furszy commented Sep 24, 2020

Fixing CWallet::GetMasternodeVinAndKeys accessing mapWallet without locking cs_wallet.
Decoupled from #1829 .

@furszy furszy self-assigned this Sep 24, 2020
random-zebra
random-zebra approved these changes Sep 24, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7f86031

@random-zebra random-zebra added this to the 5.0.0 milestone Sep 24, 2020
@furszy furszy requested a review from Fuzzbawls September 29, 2020 04:33
Fuzzbawls
Fuzzbawls approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7f86031

@furszy furszy merged commit fb94ca7 into PIVX-Project:master Oct 1, 2020
@furszy furszy deleted the 2020_missing_wallet_lock branch November 29, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

Bug Masternode Wallet

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@furszy @Fuzzbawls @random-zebra