[Refactoring] Budget, round 6: masternode vote for finalized budgets #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2020
random-zebra
force-pushed
the
202009_budget_submitvotes
branch
from
c7e4452 to
a78c07e
Compare
random-zebra
force-pushed
the
202009_budget_submitvotes
branch
from
a78c07e to
f112960
Compare
random-zebra
force-pushed
the
202009_budget_submitvotes
branch
3 times, most recently
from
f121301 to
16d1fe5
Compare
Author
|
Rebased on master. Ready for review. |
furszy
reviewed
Nov 2, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Looking pretty nice, made a first pass through the commits, only minor styling nits for now.
Author
|
Nits addressed. |
Fuzzbawls
previously approved these changes
Nov 5, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 03b925b269a2d9b9107b2a791120dc3d21808250
As we want to access the CBudgetProposal objects, to check finalized budgets, without locking cs_proposals, so we use the copy as a snapshot of the current state.
random-zebra
force-pushed
the
202009_budget_submitvotes
branch
from
03b925b to
5c0d2aa
Compare
Author
|
Rebased on master. Ready to be merged. |
furszy
added a commit
that referenced
this pull request
Nov 17, 2020
…iles c7051e7 [Cleanup] Remove masternode-budget.cpp/.h (random-zebra) e4f1f5e [MOVE-ONLY] Move CBudgetDB to budgetdb.h/cpp (random-zebra) 682067b [MOVE-ONLY] Move CBudgetManager to budgetmanager.h/cpp (random-zebra) 6053dc3 [MOVE-ONLY] move CBudgetProposal/CFinalizedBudget to separate files (random-zebra) 3d8ecaf [MOVE-ONLY] move CBudgetVote/CFinalizedBudgetVote to separate files (random-zebra) Pull request description: Based on top of - [x] #1861 Final round for this first cleanup of the budget classes. MOVE-ONLY commits. Split masternode-budget.h/.cpp in single files inside the `budget` subdir: - `budget/budgetdb.*` (CBudgetDB) - `budget/budgetmanager.*` (CBudgetManager) - `budget/budgetproposal.*` (CBudgetProposal) - `budget/budgetvote.*` (CBudgetVote) - `budget/finalizedbudget.*` (CFinalizedBudget) - `budget/finalizedbudgetvote.*` (CFinalizedBudgetVote) ACKs for top commit: furszy: looking good, utACK c7051e7 Fuzzbawls: ACK c7051e7 Tree-SHA512: 59d009110c615650cd4107b5ae0f8ed0a84652b033eb7e6b35b37d42f18631451c42326ac153e8c97818bf5b54020d2eca383ff2e12f274edcaa9d2bcf7137ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of
Starting with
[Trivial] Rename global budget object to g_budgetman(64f0840)This refactors
CFinalizedBudget::SubmitVote, moving it to the budget manager (VoteOnFinalizedBudgets), and removing the nested locking issues.It also does some trivial cleanup:
g_budgetmanCBudgetVote/CFinalizedBudgetconstructorsDumpBudgets(instead of using the global one)