Skip to content

Conversation

@furszy
Copy link

@furszy furszy commented Sep 20, 2020

For some reason mnping log category wasn't added to the logcategories vector. Discovered it trying to exclude it with debugexclude=mnping which notifies the error.

@furszy furszy self-assigned this Sep 20, 2020
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK e1969c6

@random-zebra random-zebra added Trivial extremely simple issues Util / log / libs labels Sep 20, 2020
@random-zebra random-zebra added this to the 5.0.0 milestone Sep 20, 2020
@furszy furszy added the Needs Backport Placeholder tag for anything needing a backport to prior version branches label Sep 21, 2020
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e1969c6

@random-zebra random-zebra merged commit 5aed03f into PIVX-Project:master Sep 22, 2020
furszy added a commit that referenced this pull request Sep 24, 2020
2d10e2e [Trivial][UI] Fix init messages (random-zebra)
3e8ccf0 missing mnping category added to logcategories (furszy)
f182bc8 [Cleanup] emplace CRecipient + remove extra hashing of budget objects (random-zebra)
6204902 [Refactor] Unify GetBudgetSystemCollTX and GetBudgetFinalizationCollTX (random-zebra)
8398b2e [BUG] Duplicated ReserveKey in CBudgetManager::SubmitFinalBudget() (random-zebra)
9c0d4b1 Remove unused mapRequest tracking. (furszy)
a7b3b4f miner: removing a not needed block requests tracking. (furszy)
921fc4b GUI: removing unused TransactionDesc file (static toHTML function is not being called anymore). (furszy)
d956349 GUI: transactionTablemodel, remove unused LongDescriptionRole. (furszy)

Pull request description:

  Simple back porting PR to 4.3 branch, including:

  #1853
  #1855
  #1860
  #1863

ACKs for top commit:
  random-zebra:
    utACK 2d10e2e
  Fuzzbawls:
    utACK 2d10e2e

Tree-SHA512: b23eabfc1ba1c2896782fe77b25d8edad2e0ec6dc0f3a9e78add257e4cf801605bf0f1943690bc04f70587b6d9a8d179770dd312eec40bbfa605bb3caf20cc05
@Fuzzbawls Fuzzbawls modified the milestones: 5.0.0, 4.3.0 Sep 25, 2020
@Fuzzbawls Fuzzbawls removed the Needs Backport Placeholder tag for anything needing a backport to prior version branches label Sep 26, 2020
@furszy furszy deleted the 2020_include_mnping_in_debug_exclude branch November 29, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial extremely simple issues Util / log / libs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants