[Cleanup] Removing unused and unneeded functions and members #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_remove_request_count
branch
from
cbeb4ff to
448360b
Compare
random-zebra
previously approved these changes
Sep 14, 2020
…not being called anymore).
Confusing feedback to users that we display whether a tx was broadcast to immediate neighbor nodes, given that has little indication of whether the tx propagated very far. Coming from btc@beef7ec4be725beea870a2da510d2817487601ec
furszy
force-pushed
the
2020_remove_request_count
branch
from
448360b to
5a4e416
Compare
Author
|
yeah, done 👍 |
Fuzzbawls
approved these changes
Sep 16, 2020
furszy
added
the
Needs Backport
This was referenced Sep 18, 2020
furszy
added a commit
that referenced
this pull request
Sep 24, 2020
2d10e2e [Trivial][UI] Fix init messages (random-zebra) 3e8ccf0 missing mnping category added to logcategories (furszy) f182bc8 [Cleanup] emplace CRecipient + remove extra hashing of budget objects (random-zebra) 6204902 [Refactor] Unify GetBudgetSystemCollTX and GetBudgetFinalizationCollTX (random-zebra) 8398b2e [BUG] Duplicated ReserveKey in CBudgetManager::SubmitFinalBudget() (random-zebra) 9c0d4b1 Remove unused mapRequest tracking. (furszy) a7b3b4f miner: removing a not needed block requests tracking. (furszy) 921fc4b GUI: removing unused TransactionDesc file (static toHTML function is not being called anymore). (furszy) d956349 GUI: transactionTablemodel, remove unused LongDescriptionRole. (furszy) Pull request description: Simple back porting PR to 4.3 branch, including: #1853 #1855 #1860 #1863 ACKs for top commit: random-zebra: utACK 2d10e2e Fuzzbawls: utACK 2d10e2e Tree-SHA512: b23eabfc1ba1c2896782fe77b25d8edad2e0ec6dc0f3a9e78add257e4cf801605bf0f1943690bc04f70587b6d9a8d179770dd312eec40bbfa605bb3caf20cc05
Fuzzbawls
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going further with the cleanup, have removed several unused and not needed functions and files from the GUI and the wallet. The
LongDescriptionRole(which was calling to theTransactionDescclass) is not needed anymore, just a remanent of the previous GUI. Then have gone down the rabbit hole and cleaned the methods and fields that were connected to the removed function and currently are not needed anymore.