5004e1f [Cleanup] Remove not needed budget/proposal constructors (random-zebra)
957b63e [Cleanup] Nuke CBudgetProposalBroadcast and CFinalizedBudgetBroadcast (random-zebra)
5c4eea1 [Refactor] Migrate C*Broadcast() classes to C*::GetBroadcast() (random-zebra)
5c88045 [Refactor] Initialize Gov Objects from serialized messages (random-zebra)
d0f0705 [Refactor] Remove mapSeenProposals / mapSeenFinalizedBudgets (random-zebra)
30c5599 [Refactor] Use new interfaces in CBM::GetProposal[FinBudget]Serialized() (random-zebra)
d0a959e [Refactoring] Introduce CFinalizedBudget/CBudgetProposal::GetBroadcast (random-zebra)

Pull request description:

  Continues the budget-refactoring thread.

  Remove the following classes entirely
  - `CBudgetProposalBroadcast`
  - `CFinalizedBudgetBroadcast`

  Replace them with a new dastream-based constructor and a `GetBroadcast` function (returning the serialized stream) inside `CBudgetProposal` / `CFinalizedBudget` classes.

  This allows us to get rid also of `mapSeenProposals` and `mapSeenFinalizedBudgets` and all the relative ugly code duplication (just rely on `mapProposals` and `mapFinalizedBudgets` to check for existence, and to get the broadcast messages to send).

  Based on top of
  - [x] #1845

  Starts with `[Refactoring] Introduce CFinalizedBudget/CBudgetProposal::GetBroadcast` (37c629881372e492a65ea17a4b18ad02cd53ed58)

ACKs for top commit:
  furszy:
    re utACK 5004e1f .
  Fuzzbawls:
    ACK 5004e1f

Tree-SHA512: e4750d57b069df66ca1e4bdb1e4de35c06120e17c206717b626d9b24eb76fbfbe4d81c681084f2dd6e6c2776d4a88a82a090b5c10cc549a2f9780064cbad8c69

…ndexes

d7a1c99 [Cleanup] Extra call to CBudgetMan::SetBestHeight in reconsiderblock (random-zebra)
5d0731e [Cleanup] Remove redundant Clear in CBudgetManager constructor (random-zebra)
48b723e [Budget] Remove proposal/budgets if FeeTx block is disconnected (random-zebra)
9c6173c [Budget] Introduce mapFeeTxToProposal and mapFeeTxToBudget (random-zebra)

Pull request description:

  Based on top of:
  - [x] #1851

  Starting with `[Budget] Introduce mapFeeTxToProposal and mapFeeTxToBudget` (0eb9e45)

  Since #1845 we no longer check repeatedly the active chain, when updating a budget object, we just save the height of the block including the collateral tx (ref #1845), when we first add the proposal/budget to the map.

  Therefore we need to handle the case where said block is disconnected from the chain.

  In order to do so efficiently, this PR adds two indexes (`mapFeeTxToBudget`/`mapFeeTxToProposal`), mapping collateral txids to the relative budget objects (while such objects are stored in the map).
  A simple function `CBudgetManager::RemoveByFeeTxId()` can then be called from `DisconnectBlock` when undoing transactions, in order to remove the now-conflicted budget objects (without performing any expensive search).

ACKs for top commit:
  furszy:
    nice, code review ACK d7a1c99.
  Fuzzbawls:
    ACK d7a1c99

Tree-SHA512: 9dd8a671032f79105219b7a0e3e0514b991ff92e55834f5adad4964fb9b5c1842bbb0c0995c9b504ca79c5c86115061f4a93e9b4560a63c2beaf66aa5915c2f5

…asternodeman:ProcessMessage

50e156f MasternodeMan::ProcessMessage flow calculating the mnping and mnbroadcast hash only once. (furszy)
1d8a3e4 masternodeman stripped out cs_main lock for Misbehaving from ProcessMessage entirely. (furszy)
fef42b1 Move masternodeman vin null comparison to be using IsNull + Move-only ProcessMessage below ProcessGetMNList. (furszy)
4434112 CTxIn IsNull method implemented. (furszy)
9c4e8d1 Decouple ProcessGetMNList into its own method plus strip out Misbehaving call from its flow (furszy)
befaaeb Decouple ProcessMNBroadcast into its own method plus strip out Misbehaving call from its flow. (furszy)

Pull request description:

  Built on top of #1845.

  Refactored `Masternodeman:ProcessMessage` decoupling in different methods and stripped out every `cs_main` lock for a `Misbehaving` function call.

ACKs for top commit:
  random-zebra:
    utACK 50e156f
  Fuzzbawls:
    utACK 50e156f

Tree-SHA512: 4468ba1fd1bbd983a983374de9a56453d983f0dc9def86185992ce7102ce34c8b07b559b58c65f13404676023e5e6a457fe1cf8370915e3e357678fca29bf6a4