[Miner] PoS process, calculate stakeable utxo only once. #1818
Conversation
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Found the problem with the fuctional test failing.
The list of available coins must be updated after each generated block in generate().
We were calculating the stakeable utxo before calling CreateNewBlock and inside the method (CreateCoinStake). Looping over the wallet's transactions map twice.
furszy
force-pushed
the
2020_miner_calculate_stakeable_coins_only_once
branch
from
01814d5 to
261bd22
Compare
|
rebased. |
|
Functionality tested, working as intended. NOTE: Probably unrelated, but in case if it helps -> I'm not sure if there is an issue with this PR or it's just a particular issue on my end, but starting the wallet on testnet with this PR pulled on top of latest master resulted with "scanning block" (although GUI was saying "scanning block ...", it was actually doing sync from scratch (I believe) because it was using the bandwidth just like it is using when doing the sync from scratch. |
|
@NoobieDev12 not an issue of this PR. About the conflicted tx state. It's ok, not an issue. As your node was syncing, your wallet had transactions that were not part of the main chain at a certain point. Once the block which includes them was processed, the transaction state got updated properly. |
3 participants
Work on top of #1816 and part of #1817 coinstake transaction creation speedup goal. Starting on 01814d5
Improving the following situation: we are calculating the stakeable utxo twice for the same PoS block creation process (looping over the entire wallet's transactions map twice), one before calling
CreateNewBlockinCheckForCoinsand the second one inside theCreateNewBlockmethod when we callCWallet::CreateCoinStake.This PR fixes it adding an unique available coins vector calculated before the block creation, only once per try, in the
CheckForCoinsfunction and feedingCreateNewBlockwith it.