[Wallet] Speedup coinstake creation removing redundancies. #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_wallet_createCoinStake_cleanup
branch
from
bc0e56f to
4f5329c
Compare
random-zebra
previously approved these changes
Aug 25, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
nice cleanup 👍 utACK 4f5329c6a5fa63a77ed3145fa73faf274a6c20f6
Fuzzbawls
previously approved these changes
Sep 6, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 4f5329c6a5fa63a77ed3145fa73faf274a6c20f6
|
Needs rebase |
The usage of unique_ptr on this context is just wrong, same as the double for loop over all of the available outputs.
furszy
force-pushed
the
2020_wallet_createCoinStake_cleanup
branch
from
4f5329c to
9fb497d
Compare
Author
|
rebased |
random-zebra
approved these changes
Sep 6, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
re-utACK 9fb497d and merging...
furszy
added a commit
that referenced
this pull request
Sep 8, 2020
261bd22 Staking process: calculate the stakeable utxo only once. (furszy) Pull request description: Work on top of #1816 and part of #1817 coinstake transaction creation speedup goal. Starting on 01814d5 Improving the following situation: we are calculating the stakeable utxo twice for the same PoS block creation process (looping over the entire wallet's transactions map twice), one before calling `CreateNewBlock` in `CheckForCoins` and the second one inside the `CreateNewBlock` method when we call `CWallet::CreateCoinStake`. This PR fixes it adding an unique available coins vector calculated before the block creation, only once per try, in the `CheckForCoins` function and feeding `CreateNewBlock` with it. ACKs for top commit: random-zebra: utACK 261bd22 Tree-SHA512: f553667fd48d0d7eb78e2ce87b438c915dc216b32e0426e0214caa52f16a2627143319233c6dd93e4b5d45dcfbb825787c1b39cd209c8e6516bf2391f0516e00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement over the coinstake transaction creation flow, it will speed up the process a lot.
Removing a for loop redundancy (it was looping over the available outputs twice), removing a simply bad usage of unique_ptr, guarding
chainActiveaccess, removing unused zPoS code and few smaller warnings fixes.