[Refactor] Cleanup access to chainActive in a few places #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
previously approved these changes
Aug 18, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK d0739e496ae129b0a822538edd5b950ec0d93077
furszy
reviewed
Aug 18, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Code review ACK d0739e496ae129b0a822538edd5b950ec0d93077 .
Left few comments under the same code aspect.
random-zebra
force-pushed
the
202008_GetChainTip
branch
from
d0739e4 to
6dcd48b
Compare
Author
|
Updated, addressing @furszy's comments. |
furszy
previously approved these changes
Aug 19, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
cool, ACK 6dcd48bb09ceaeddd6b75d36d358512cb806a656
random-zebra
force-pushed
the
202008_GetChainTip
branch
from
6dcd48b to
def064f
Compare
Author
|
Rebased to fix a minor conflict with #1809 just merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor a few places in masternode/rpc code where
chainActive.Tip()orchainActive.Height()is used.Make use of the function
GetChainTip(), moved from miner to main, which returns a more reliable pointer (from mapBlockIndex, instead of chainActive).Remove redundant checks in masternode's
GetBlockHash(e.g. see comments in #1791).