Skip to content

[Core] Remove priority estimation #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
random-zebra merged 2 commits into from
Aug 23, 2020
Merged

[Core] Remove priority estimation #1788

random-zebra merged 2 commits into from
Aug 23, 2020

Conversation

@random-zebra
Copy link

@random-zebra random-zebra commented Aug 4, 2020 •
edited
Loading

Based on top of

This removes the functionality behind estimatepriority and estimatesmartpriority (from bitcoin#7730).

Instead of just deprecating the relative RPC commands, I think we can outright remove them, as estimatepriority was added only in latest minor release (4.2), and estimatesmartpriority is introduced in a PR not even merged yet (#1787).

@random-zebra random-zebra added this to the 5.0.0 milestone Aug 4, 2020
@random-zebra random-zebra self-assigned this Aug 4, 2020
@random-zebra
Copy link
Author

random-zebra commented Aug 18, 2020

Rebased on master. Ready for review.

furszy
furszy previously approved these changes Aug 18, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK caafdb2

@random-zebra random-zebra requested a review from Fuzzbawls August 19, 2020 11:41
@random-zebra
[Core] Remove priority estimation
041f62e 
>>> backports bitcoin/bitcoin#3c03dc2cfc07077aabef4c0fdd31435842a26a77
@random-zebra
[Cleanup] Nuke estimate(smart)priority from the RPC interface
2da16f7
@random-zebra
Copy link
Author

random-zebra commented Aug 19, 2020

Rebased.

Fuzzbawls
Fuzzbawls approved these changes Aug 22, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2da16f7

furszy
furszy approved these changes Aug 22, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2da16f7

@random-zebra random-zebra merged commit 823ba8e into PIVX-Project:master Aug 23, 2020
@random-zebra random-zebra modified the milestones: 5.0.0, 4.3.0 Sep 10, 2020
@Fuzzbawls Fuzzbawls added Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes and removed Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes labels Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@furszy furszy furszy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@random-zebra random-zebra

Labels

RPC TX fees and policy Upstream

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@random-zebra @furszy @Fuzzbawls