[Net] cs_vSend-cs_main deadlock detection fixed. #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n disconnection coming from btc@905bc68d05595f41cca36b3df83accd10c00cc48
cs_vSend is used for two purposes - to lock the datastructures used to queue messages to place on the wire and to only call SendMessages once at a time per-node. I believe SendMessages used to access some of the vSendMsg stuff, but it doesn't anymore, so these locks do not need to be on the same mutex, and also make deadlocking much more likely.
Technically cs_sendProcessing is entirely useless now because it is only ever taken on the one MessageHandler thread, but because there may be multiple of those in the future, it is left in place
Fuzzbawls
requested changes
Aug 1, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
missing a header include for CMake linux builds
Author
|
updated, ready for review. |
Fuzzbawls
approved these changes
Aug 2, 2020
Fuzzbawls
added
the
Needs Backport
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
…n disconnection coming from btc@905bc68d05595f41cca36b3df83accd10c00cc48 Github-Pull: PIVX-Project#1780 Rebased-From: 0544cc6
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
Github-Pull: PIVX-Project#1780 Rebased-From: 2d71f05
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
Github-Pull: PIVX-Project#1780 Rebased-From: e48c0d3
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
Github-Pull: PIVX-Project#1780 Rebased-From: f9c458a
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
cs_vSend is used for two purposes - to lock the datastructures used to queue messages to place on the wire and to only call SendMessages once at a time per-node. I believe SendMessages used to access some of the vSendMsg stuff, but it doesn't anymore, so these locks do not need to be on the same mutex, and also make deadlocking much more likely. Github-Pull: PIVX-Project#1780 Rebased-From: ec23964
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
Technically cs_sendProcessing is entirely useless now because it is only ever taken on the one MessageHandler thread, but because there may be multiple of those in the future, it is left in place Github-Pull: PIVX-Project#1780 Rebased-From: c452676
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
Github-Pull: PIVX-Project#1780 Rebased-From: b954796
furszy
added a commit
that referenced
this pull request
Aug 18, 2020
dc0ed71 [BUG][GUI] Don't append cold-stake records twice (random-zebra) 91adcd7 masternode: CalculateScore and GetBlockHash accessing to chainActive without cs_main fix. (furszy) eeb112f GetMasternodeInputAge: Missing cs_main lock (furszy) 52ec12d refactor: decouple decompose coinstake from TransactionRecord::decomposeTransaction. (furszy) 51a8389 [BUG] Properly copy fCoinStake memeber between CTxInUndo and CCoins Github-Pull: #1796 Rebased-From: acf757b (random-zebra) 5c3caa4 lock cs_main for Misbehaving (furszy) 5c629d8 openssl.org dependency download link changed (CryptoDev-Project) 11aa63c Do not try to resend transactions if the node is importing or in IBD. (furszy) c59b62e [Core] Remove BIP30 check (random-zebra) 3f05eba include missing atomic to make CMake linux happy. (furszy) f0cfd88 Make the cs_sendProcessing a LOCK instead of a TRY_LOCK (Matt Corallo) d38e28c Split CNode::cs_vSend: message processing and message sending (Matt Corallo) 7561b18 Remove double brackets in addrman (Matt Corallo) 63c629b Fix AddrMan locking (Matt Corallo) f78cec4 Make fDisconnect an std::atomic (Matt Corallo) ec56cf5 net: fix a few cases where messages were sent rather than dropped upon disconnection (furszy) 7697085 Acquire cs_main lock before cs_wallet during wallet initialization (random-zebra) c796593 Remove bogus assert on number of oubound connections. (Matt Corallo) 7521065 wallet: Ignore MarkConflict if block hash is not known (random-zebra) 72042ac Move disconnectBlocks logging to use __func__ instead of hardcoded method name. (furszy) 0f66764 Simplify DisconnectBlock arguments/return value (furszy) cca4a8c Split logic to undo txin's off DisconnectBlock (furszy) 0f883e6 Cleaner disconnectBlock flow for coinbase and zerocoin txs. (furszy) a7cbc46 Move UndoWriteToDisk() and UndoReadFromDisk() to anon namespace (random-zebra) de5a405 Decouple CBlockUndo from CDiskBlockPos (jtimon) 671143c Decouple miner.o and txmempool.o from CTxUndo (random-zebra) 9419228 Decouple CCoins from CTxInUndo (jtimon) Pull request description: Backports the following PRs to the `4.2` branch: #1746 #1735 #1767 #1769 #1781 #1780 #1775 #1783 #1750 #1785 #1796 #1776 #1791 ACKs for top commit: furszy: Added #1805. utACK dc0ed71. random-zebra: utACK dc0ed71 Tree-SHA512: 0e59c9e751597b1b6f9a419e117946cec468dffdb921c882a44e5770ecb1a36b7d3d25f8c7f97d48bb3d59f136492842c08969901512d957a17bfaec6aece449
random-zebra
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running 4.2 branch with
enable-debug.Fixing:
Plus, added few more minor possible races fixes too.
Back porting:
bitcoin#8862
bitcoin#9225
bitcoin#9535