Skip to content

Conversation

@random-zebra
Copy link

@random-zebra random-zebra commented Jul 29, 2020

Builds on top of

Use SipHash for node eviction and add more test vectors for siphash
(backports bitcoin#8173)

@random-zebra
Copy link
Author

Additional commit, to implement SipHash in python, cherry-picked from bitcoin/bitcoin@9c8593d

@furszy
Copy link

furszy commented Aug 3, 2020

#1768 merged, ready for rebase

@random-zebra random-zebra force-pushed the 202007_siphash_testing branch from 772e5a9 to f980d43 Compare August 3, 2020 10:47
@random-zebra
Copy link
Author

Rebased. Ready for review.

Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, utACK f980d43

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f980d43

@furszy furszy merged commit bda654c into PIVX-Project:master Aug 5, 2020
furszy added a commit that referenced this pull request Aug 19, 2020
83512d2 [Trivial] Mark CCoinsView child classes methods as override (random-zebra)
5643075 Store/allow tx metadata in all undo records (random-zebra)
8c4add4 Report on-disk size in gettxoutsetinfo (random-zebra)
6cb2989 Remove/ignore tx version in utxo and undo (random-zebra)
03b9724 Add specialization of SipHash for 256 + 32 bit data (Pieter Wuille)
e3cd496 Introduce CHashVerifier to hash read data (random-zebra)
10baa70 error() in disconnect for disk corruption, not inconsistency (random-zebra)
802f8c8 Add SizeEstimate to CDBBatch (Pieter Wuille)

Pull request description:

  This backports the commits listed as "Preparation" in bitcoin#10195.
  The rest will be included in a followup PR.

  Built on top of:
  - [x] #1772
  - [x] #1771
  - [x] #1793

  Here we:
  - add in-memory size estimation of a LevelDB batch
  - remove the usage of `error()` in ApplyTxInUndo/DisconnectBlock
  - Introduce the new CHashVerifier class to hash read data
  - Add a specialized version of SipHash for tuples of 256 bits and 32 bits data
  - Remove the transaction version from utxo and undo data structures
  - Add on-disk size of the utxo set to gettxoutsetinfo
  - store tx metadata in all undo records, instead of records corresponding only to the last output of a tx being spent.

ACKs for top commit:
  furszy:
    looking good, utACK 83512d2.
  Fuzzbawls:
    utACK 83512d2

Tree-SHA512: 7db730058ae208535aad5f5989abb9c55fd3722b79efef24fdd8c717687b67272bddaeae5e5a4a2d3e97626a7ec62a5d1ebdb5af0233f4a950b5a0c0b154484f
@random-zebra random-zebra modified the milestones: 5.0.0, 4.3.0 Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants