[Build] Bump minimum libc to 2.17 for release binaries #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer needed when requiring glibc 2.17 as our minimum version.
The clock_* functions from librt were merged into glibc as part of the 2.17 release, so this is no longer needed.
furszy
approved these changes
Aug 4, 2020
Fuzzbawls
added
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up the minimum supported libc version to 2.17, which is necessary moving forward with sapling work.
2.17 was chosen as that is what CentOS 7 includes, which won't reach EOL until 2024.
Also included here are a couple cleanups for checks or backwards compatibility code that are rendered moot with the libc version bump.