[Validation] DisconnectBlock updates. #1735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be rebased now (#1733 merged). |
Author
|
yep, doing it |
furszy
force-pushed
the
2020_main_disconnectBlock_updates
branch
from
a25dbb0 to
7bf3699
Compare
Author
|
rebased |
random-zebra
previously approved these changes
Jul 13, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK 51de6740575d1771ed37f406b950d57490df27fd
furszy
force-pushed
the
2020_main_disconnectBlock_updates
branch
from
51de674 to
42257a2
Compare
random-zebra
previously approved these changes
Jul 13, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK 42257a21badb34f3f1204212c269b6a50fd10bf1
coming from btc@eb1c2cd37f75cf4d0e85970932b9774b2d073225
coming from btc@db994b2de93f52c9e7bed8529ca925de5064a46f
furszy
force-pushed
the
2020_main_disconnectBlock_updates
branch
from
42257a2 to
d4cf6c8
Compare
Author
|
rebased, had conflicts with recently merged #1746 |
Fuzzbawls
approved these changes
Jul 26, 2020
Fuzzbawls
changed the title
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
Github-Pull: PIVX-Project#1735 Rebased-From: a3a4ab5
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
coming from btc@eb1c2cd37f75cf4d0e85970932b9774b2d073225 Github-Pull: PIVX-Project#1735 Rebased-From: 6d2ea62
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
coming from btc@db994b2de93f52c9e7bed8529ca925de5064a46f Github-Pull: PIVX-Project#1735 Rebased-From: 17e9b8e
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Aug 13, 2020
…thod name. Github-Pull: PIVX-Project#1735 Rebased-From: d4cf6c8
furszy
added a commit
that referenced
this pull request
Aug 18, 2020
dc0ed71 [BUG][GUI] Don't append cold-stake records twice (random-zebra) 91adcd7 masternode: CalculateScore and GetBlockHash accessing to chainActive without cs_main fix. (furszy) eeb112f GetMasternodeInputAge: Missing cs_main lock (furszy) 52ec12d refactor: decouple decompose coinstake from TransactionRecord::decomposeTransaction. (furszy) 51a8389 [BUG] Properly copy fCoinStake memeber between CTxInUndo and CCoins Github-Pull: #1796 Rebased-From: acf757b (random-zebra) 5c3caa4 lock cs_main for Misbehaving (furszy) 5c629d8 openssl.org dependency download link changed (CryptoDev-Project) 11aa63c Do not try to resend transactions if the node is importing or in IBD. (furszy) c59b62e [Core] Remove BIP30 check (random-zebra) 3f05eba include missing atomic to make CMake linux happy. (furszy) f0cfd88 Make the cs_sendProcessing a LOCK instead of a TRY_LOCK (Matt Corallo) d38e28c Split CNode::cs_vSend: message processing and message sending (Matt Corallo) 7561b18 Remove double brackets in addrman (Matt Corallo) 63c629b Fix AddrMan locking (Matt Corallo) f78cec4 Make fDisconnect an std::atomic (Matt Corallo) ec56cf5 net: fix a few cases where messages were sent rather than dropped upon disconnection (furszy) 7697085 Acquire cs_main lock before cs_wallet during wallet initialization (random-zebra) c796593 Remove bogus assert on number of oubound connections. (Matt Corallo) 7521065 wallet: Ignore MarkConflict if block hash is not known (random-zebra) 72042ac Move disconnectBlocks logging to use __func__ instead of hardcoded method name. (furszy) 0f66764 Simplify DisconnectBlock arguments/return value (furszy) cca4a8c Split logic to undo txin's off DisconnectBlock (furszy) 0f883e6 Cleaner disconnectBlock flow for coinbase and zerocoin txs. (furszy) a7cbc46 Move UndoWriteToDisk() and UndoReadFromDisk() to anon namespace (random-zebra) de5a405 Decouple CBlockUndo from CDiskBlockPos (jtimon) 671143c Decouple miner.o and txmempool.o from CTxUndo (random-zebra) 9419228 Decouple CCoins from CTxInUndo (jtimon) Pull request description: Backports the following PRs to the `4.2` branch: #1746 #1735 #1767 #1769 #1781 #1780 #1775 #1783 #1750 #1785 #1796 #1776 #1791 ACKs for top commit: furszy: Added #1805. utACK dc0ed71. random-zebra: utACK dc0ed71 Tree-SHA512: 0e59c9e751597b1b6f9a419e117946cec468dffdb921c882a44e5770ecb1a36b7d3d25f8c7f97d48bb3d59f136492842c08969901512d957a17bfaec6aece449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1733.
Straightforward PR, no functional changes. Purely code cleanup and refactoring around the
DisconnectBlockfunction.