[WIP] Miner code reworked from upstream 6898 #1727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
21 tasks
random-zebra
added
Block Generation
|
This can be rebased now |
Author
|
let's merge #1809 first. It will make the rebase a little bit simpler. |
Fuzzbawls
added a commit
that referenced
this pull request
Aug 20, 2020
…ateNewBlock bcac96a miner: decouple SolveProofOfStake flow from CreateNewBlock function. (furszy) 04ac18c miner: decouple zPIV duplicated serials checks from CreateNewBlock function. (furszy) Pull request description: No functional changes, purely a code decoupling over the zPIV duplicated serials validations at the miner code (which we will remove in the next months). Doing this to make the old #1727 a little bit easier to rebase + adapt to current master. ACKs for top commit: random-zebra: utACK bcac96a Fuzzbawls: utACK bcac96a Tree-SHA512: d207fc4e532a7311159de2d0cd0a1caee4c7efb01a3a9ce1c68f5872aa8e047e1929ee45fea6853a9aa6386a72abd48fa64c0309e8ae00d7a3f26a8d065df89d
coming from btc@553cad94e29c33872b60d97b8574ed2773355f0b
furszy
force-pushed
the
2020_05_miner_updated_6898
branch
from
d6bbf3b to
d1ef1c0
Compare
|
Needs rebase. |
Fuzzbawls
changed the title
Collaborator
|
We've discussed this PR a couple times in meetings, and it is largely un-necessary (or at most, non-essential), but I'd like to see it re-analyzed as upstream's work on this front ultimately led to the removal of the Boost |
Author
|
feel free of tackling it in another PR, all good for me. Can close this one at any time. Zero priority for me to continue with this work before v5. |
Author
|
Closing this, can be revived after v5 if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #1725.
Finishing the last commit back port of bitcoin#6898 and added bitcoin#7539 on top.