-
Notifications
You must be signed in to change notification settings - Fork 725
[RPC] Register calls where they are defined #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the submission @Liquid369 ! |
|
Also, it does not compile currently. |
|
this will not work if it's not connected to the code. Need to back port the register interface and connect it to init.cpp and test_pivx.cpp. |
|
Ah yes I forgot test_pivx.cpp. My apologies on init.cpp being missed. I had done the work and realized my repo was about 400ish commits behind and then refactored. I guess I missed init.cpp additions for adding in rpc/register.h Do you have a naming suggestion as per the changes I am bringing in for the duplicated functions? I will rebase ontop of 1702 for fixing conflicts and then fix the subsequent issues pointed out by furzy |
|
It doesnt even show my Makefile changes might not have staged those. I will work on it just awaiting suggestions I asked about above. |
|
just use the rpc file name for the register methods. Same convention as in the other places. |
|
I think I am going to close this and reopen it. So rebase ontop of #1702 Alongside other comments in this. Agreed? |
|
#1702 contains 7307. You can work only on 7766. Feel free to close it and open a new one or force push the work here. |
Follow up to PR #1702
Bitcoin backport bitcoin#7766
Splitting out registration methods from rpcserver.cpp.
Making for easier RPC command additions and not needing to rebuild everything in rpcserver.h includes.