Skip to content

Conversation

@Liquid369
Copy link
Member

Follow up to PR #1702

Bitcoin backport bitcoin#7766

Splitting out registration methods from rpcserver.cpp.

Making for easier RPC command additions and not needing to rebuild everything in rpcserver.h includes.

@random-zebra
Copy link

Thanks for the submission @Liquid369 !
This should be rebased on top of #1702, to not revert its changes (e.g. threadSafe and reqWallet members have been removed from CRPCCommands), and avoid future conflicts after its merge.

@random-zebra random-zebra changed the title rpc: Register calls where they are defined [RPC] Register calls where they are defined Jun 28, 2020
@random-zebra random-zebra added this to the 4.2.0 milestone Jun 28, 2020
@random-zebra
Copy link

Also, it does not compile currently.

@furszy
Copy link

furszy commented Jun 28, 2020

this will not work if it's not connected to the code. Need to back port the register interface and connect it to init.cpp and test_pivx.cpp.
And there are duplicated functions RegisterBlockchainRPCCommands. Need to have unique names on each rpc file.

@Liquid369
Copy link
Member Author

Ah yes I forgot test_pivx.cpp. My apologies on init.cpp being missed. I had done the work and realized my repo was about 400ish commits behind and then refactored. I guess I missed init.cpp additions for adding in rpc/register.h

Do you have a naming suggestion as per the changes I am bringing in for the duplicated functions?

I will rebase ontop of 1702 for fixing conflicts and then fix the subsequent issues pointed out by furzy

@Liquid369
Copy link
Member Author

It doesnt even show my Makefile changes might not have staged those.

I will work on it just awaiting suggestions I asked about above.

@furszy
Copy link

furszy commented Jun 28, 2020

just use the rpc file name for the register methods. Same convention as in the other places.

@Liquid369
Copy link
Member Author

I think I am going to close this and reopen it.
After finishing the work on bitcoin#7766
I noticed in the comments it is worked ontop of bitcoin#7307
bitcoin#7307

So rebase ontop of #1702
Backport bitcoin#7307
Backport bitcoin#7766

Alongside other comments in this.

Agreed?

@furszy
Copy link

furszy commented Jun 28, 2020

#1702 contains 7307. You can work only on 7766.

Feel free to close it and open a new one or force push the work here.
Just take your time to understand the flow and test it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants