Skip to content

Prepare for non-Base58 addresses [Step 2] #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furszy merged 3 commits into from
Jun 28, 2020
Merged

Prepare for non-Base58 addresses [Step 2] #1677

furszy merged 3 commits into from
Jun 28, 2020

Conversation

@furszy
Copy link

@furszy furszy commented Jun 12, 2020 •
edited
Loading

Mixed few things here:

  1. Follow up over Prepare for non-Base58 addresses [Step 1] #1593 work. The only remaining places that are not using the destination methods are in the walletmodel and wallet objects (next PR), the rest were all already migrated.
  2. CBitcoinSecret with {Encode,Decode}Secret (adapted version of upstream@32e69fa0).
  3. Unused code removal (second commit).

@furszy furszy self-assigned this Jun 12, 2020
@furszy furszy force-pushed the 2020_more_base58_wrapper_work branch 2 times, most recently from ad77fdc to a10afb3 Compare June 12, 2020 07:55
@furszy furszy mentioned this pull request Jun 12, 2020
Merged
@furszy furszy requested a review from random-zebra June 15, 2020 04:44
random-zebra
random-zebra reviewed Jun 15, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from visual inspection.
Only the usual minor performance nit about the use of IsValidDestinationString before DecodeDestination.

@furszy furszy force-pushed the 2020_more_base58_wrapper_work branch from a10afb3 to 422d2d3 Compare June 17, 2020 20:45
@furszy
Copy link
Author

furszy commented Jun 17, 2020

Rebased due conflicts with a recently merged PR.

@furszy furszy requested review from Fuzzbawls and random-zebra June 23, 2020 03:57
@random-zebra random-zebra added this to the 4.2.0 milestone Jun 23, 2020
random-zebra
random-zebra approved these changes Jun 23, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 422d2d3

Fuzzbawls
Fuzzbawls approved these changes Jun 27, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 422d2d3

@furszy furszy merged commit 95fefe9 into PIVX-Project:master Jun 28, 2020
@furszy furszy deleted the 2020_more_base58_wrapper_work branch November 29, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

Upstream Wallet

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@furszy @Fuzzbawls @random-zebra