[Core] Separate Consensus CheckTxInputs and GetSpendHeight in CheckInputs #1673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the const Consensus::Params& consensus = ::Params().GetConsensus(); |
Coming from btc@eba2f06
furszy
force-pushed
the
2020_checkTxInputs_split
branch
from
410031f to
e27420e
Compare
Author
|
Nice :) , travis loves you @random-zebra |
Fuzzbawls
changed the title
Fuzzbawls
changed the title
Fuzzbawls
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from bitcoin#6061
Refactor needed for an upcoming work, no functional changes.
Had to do something little bit dirty to be able to get Consensus::Params from inside the Consensus namespace (struct
Paramsname clashes with global methodParams()) and not have any functional change there.Point of discussion for a later PR: could be moved to a function argument or check if there is another workaround to distinguish between the name clash.