[Refactoring] CValidationState logging #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202006_validation-error-spam
branch
from
f128da2 to
281cb2d
Compare
furszy
previously approved these changes
Jun 11, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Great work!, liked it a lot. code review ACK 10cba02 . Can be merged at any time for me.
random-zebra
force-pushed
the
202006_validation-error-spam
branch
from
10cba02 to
8b375c7
Compare
Author
|
Rebased on master due to conflicts after merging #1673 |
1 task
- backports bitcoin/bitcoin@fbf44e6 Add a field `strDebugMessage` which can be passed to DoS or Invalid, and queried using GetDebugMessage() to add extra troubleshooting information to the validation state.
- backports bitcoin/bitcoin@dc58258 Add status codes specific to AcceptToMempool procession of transactions. These can never happen due to block validation, and must never be sent over the P2P network. Add assertions where appropriate.
- backports bitcoin/bitcoin@9003c7c It is necessary to be able to concisely log a validation state. Convert CValidationState to a human-readable message for logging.
- backports bitcoin/bitcoin@6cab808 Remove unnecessary direct logging in CheckTransaction, AcceptToMemoryPool, CheckTxInputs, CScriptCheck::operator() All status information should be returned in the CValidationState. Relevant debug information is also added to the CValidationState using the recently introduced debug message. Do keep the "BUG! PLEASE REPORT THIS! ConnectInputs failed against MANDATORY but not STANDARD flags" error as it is meant to appear as bug in the log.
- backports bitcoin/bitcoin@66daed5 Add detailed state information to the errors, as it is no longer being logged downstream. Also add the state information to mempool rejection debug message in ProcessMessages.
Move mempool rejections to debug category `mempoolrej`, to make it possible to show them without enabling the entire category `mempool` which is high volume.
random-zebra
force-pushed
the
202006_validation-error-spam
branch
from
8b375c7 to
ca489c9
Compare
Author
|
Rebased again due to conflicts with #1668 just merged. |
Fuzzbawls
approved these changes
Jun 20, 2020
furszy
approved these changes
Jun 20, 2020
1 task
random-zebra
added a commit
that referenced
this pull request
Jun 27, 2020
a0de4da [Wallet] Abandon tx in CommitTransaction if ATMP fails (random-zebra) f3e07f7 Expose FormatStateMessage (Alex Morcos) Pull request description: This is an alternative to #1664. It takes the opposite approach. When ATMP fails in `CommitTransaction`, instead of just returning the txid (hoping that the failure is not permanent) try to directly abandon the transaction. Save the result of these operations in a new struct `CWallet::CommitResult`, and use it to give a detailed feedback to the user (via log lines, JSON-RPC errors and GUI dialogs). Based on top of: - [x] #1670 This PR also cherry-picks 5f12263 from bitcoin#6898, in order to use `FormatStateMessage` outside of main. ACKs for top commit: furszy: ACK a0de4da Fuzzbawls: ACK a0de4da Tree-SHA512: 5ae372f97eeed017002628646eee3f559af6dc488e1b24541b29f5ce763412fb569e057933468fc828a2aec3f2c17e2d818130b72d41c73524cfa90680877d23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CValidationState::chRejectCodeto intCValidationState::strDebugMessagefor optional informationFormatStateMessagefunction to convert CValidationState to a human-readable messageCheckTransaction,AcceptToMemoryPool,CheckTxInputs,CScriptCheck::operator()CheckBlockandConnectBlockBackported from: