Better sigcache implementation (CuckooCache) #1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to include the cuckoocache header in the makefile to be able to compile on all platforms (ref: bitcoin#9393). |
Author
|
done, updated. I didn't check travis output. |
|
This can be rebased now. |
SQUASHME: Change cuckoocache to only work for powers of two, to avoid mod operator SQUASHME: Update Documentation and simplify logarithm logic SQUASHME: OSX Build Errors SQUASHME: minor Feedback from sipa + bluematt SQUASHME: DOCONLY: Clarify a few comments.
SQUASHME: Update Tests for other SQUASHMEs
- If the -maxsigcachesize parameter is set to zero, setup a minimum sized sigcache (2 elements) rather than segfaulting. - Handle maxsigcachesize being negative - Handle maxsigcachesize being too large
It was refactored into multiple functions in 0cc8b6b.
This moves the SignatureCacheHasher to the sigcache header, out of the anonymous namespace, so that the tests can import it.
Author
|
rebased. |
random-zebra
approved these changes
Jun 23, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Really nice backport. Tested ACK 2749d0a
Fuzzbawls
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1668.
Part of the back port series to get us closer to upstream's sigcache current state.
The main ones are: