[Backport] Make sigcache faster, more efficient, larger #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2020_6918_backport
branch
from
31829ff to
6706c20
Compare
Fuzzbawls
approved these changes
Jun 18, 2020
random-zebra
added a commit
that referenced
this pull request
Jul 3, 2020
2749d0a build: Include cuckoocache header in Makefile (furszy) 791a51f Deduplicate SignatureCacheHasher (Jeremy Rubin) 7a5918a Decrease testcase sizes in cuckoocache tests (Jeremy Rubin) 8ef3cc9 Trivial: fix comments referencing AppInit2 (Marko Bencun) f21b122 Ensure `-maxsigcachesize` is in valid range (John Newbery) 464b922 Add unit tests for the CuckooCache (Jeremy Rubin) 77e3b1e Add CuckooCache implementation and replace the sigcache map_type with it (Jeremy Rubin) Pull request description: Built on top of #1668. Part of the back port series to get us closer to upstream's sigcache current state. The main ones are: * bitcoin#8895 * bitcoin#9480 * bitcoin#9393 ACKs for top commit: random-zebra: Really nice backport. Tested ACK 2749d0a Fuzzbawls: utACK 2749d0a Tree-SHA512: 22f760edc928790f29a7bbd6e907a561b7ad266b6cc5e85f207206e0f39ae3e4328ec57c0be772c96036a15559b13f6956bea5762cace10f3a560090aeb6758b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from bitcoin#6918 .
This is the first step towards an up-to-date sigcache. Next one will be to back port the CuckooCache implementation.