Skip to content

[P2P] Do not set extra flags for unfiltered DNS seed results #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furszy merged 1 commit into from
May 14, 2020
Merged

[P2P] Do not set extra flags for unfiltered DNS seed results #1618

furszy merged 1 commit into from
May 14, 2020

Conversation

@Fuzzbawls
Copy link
Collaborator

@Fuzzbawls Fuzzbawls commented May 12, 2020 •
edited
Loading

Backport of bitcoin#8208 based on top of #1616 (Only the last commit is important here). Part of #1374.

Original Description:

Any flag set in nRelevantServices would propagate to all CAddress results retrieved from the DNS seed, even if that DNS seed does not support filtering.

Fix this by making the name adaptation function also update the passed in flags.

Furthermore, move that from from DNSSeedData to net. Structs in chainparams should be data only.

@Fuzzbawls Fuzzbawls added this to the 5.0.0 milestone May 12, 2020
@Fuzzbawls Fuzzbawls self-assigned this May 12, 2020
@random-zebra
Copy link

random-zebra commented May 13, 2020

Concept ACK. Can be rebased, now that #1616 is merged.

@Fuzzbawls Fuzzbawls force-pushed the 2020_simplerservices branch from 2f0fc00 to 9107379 Compare May 13, 2020 21:15
@Fuzzbawls
Copy link
Collaborator Author

Fuzzbawls commented May 13, 2020

rebased

@Fuzzbawls Fuzzbawls mentioned this pull request May 13, 2020
Closed
21 tasks
random-zebra
random-zebra approved these changes May 14, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9107379

furszy
furszy approved these changes May 14, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9107379

@furszy furszy merged commit 077ab3d into PIVX-Project:master May 14, 2020
@lyricidal lyricidal mentioned this pull request Dec 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@furszy furszy furszy approved these changes

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Fuzzbawls Fuzzbawls

Labels

P2P Upstream

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Fuzzbawls @random-zebra @furszy @sipa