[GUI][Bug] CoinControl payAmounts and nBytes calculation #1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2020
|
ACK f526ffa |
ambassador000
previously approved these changes
May 14, 2020
ambassador000
left a comment
ambassador000
left a comment
There was a problem hiding this comment.
Functionality tested, working as intended.
furszy
previously approved these changes
May 23, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
utACK f526ffa.
Left a comment for a future improvement in this area.
random-zebra
force-pushed
the
202005_GUI_coincontrol-fix1
branch
from
f526ffa to
23c4c41
Compare
Author
|
Updated first commit, removing |
random-zebra
force-pushed
the
202005_GUI_coincontrol-fix1
branch
from
23c4c41 to
0f23f40
Compare
Author
|
Rebased. |
furszy
approved these changes
Jun 9, 2020
Fuzzbawls
approved these changes
Jun 9, 2020
random-zebra
added a commit
that referenced
this pull request
Jun 17, 2020
2ad58fd [GUI] CoinControlDialog: fix SelectAll / UnselectAll (random-zebra) Pull request description: Based on top of - [x] #1611 Only last commit is new. This updates the flow of the toggle button SelectAll/UnselectAll in the coin control dialog (`pushButtonSelectAll`). - use directly the checked state of the button, instead of caching it in a separate variable `fSelectAllToggled`. - when the button is in checked ("Unselect all") state, reset it to its initial state (unchecked, with "Select all" label) if all the entries are either manually deselected, or automatically cleared after a spend) Closes point n.3 of #1609 ACKs for top commit: Fuzzbawls: ACK 2ad58fd furszy: utACK 2ad58fd Tree-SHA512: 9f63cf2c99ebe887a89b6b17753ea7f398594860069ed694b6ee33bb2157606fa63336647d23b4df8ff36a8c7249320694a30f9d9e1d30a0200256a8267f9622
YuurinBee
added a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
payAmounts were never set in CoinControlDialog, thus
nPayAmountwas always zero.This resulted in two bugs:
nDustandnChangewere always zero, thus their labels were never usedThis PR removes some unused leftover, connects payAmounts (both from send and from coldstaking widgets) and fixes the tx-size calculation, considering also the cold-staking scripts (either as inputs and/or outputs/delegations).
Fixes point n.2 of #1609