[Cleanup][GUI] Nuke zPIV from the GUI #1549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202004_GUI_remove_zPIV_controls
branch
from
7807f96 to
199c81e
Compare
random-zebra
added
the
Needs Release Notes
random-zebra
force-pushed
the
202004_GUI_remove_zPIV_controls
branch
from
199c81e to
6853f5b
Compare
Author
|
Rebased and updated PR description with reference to tracking issue. |
random-zebra
force-pushed
the
202004_GUI_remove_zPIV_controls
branch
from
6853f5b to
b363595
Compare
furszy
reviewed
Jun 3, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Concept ACK, code looking good. Left only a minor comment.
random-zebra
force-pushed
the
202004_GUI_remove_zPIV_controls
branch
from
b363595 to
6690da5
Compare
Collaborator
|
some further cleanup can be done in Index: src/qt/pivx/forms/topbar.ui
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/qt/pivx/forms/topbar.ui (revision 511d18c008e736b9a738b90a8f5e7ab4b38e67d5)
+++ src/qt/pivx/forms/topbar.ui (date 1591231596751)
@@ -123,75 +123,6 @@
</property>
</widget>
</item>
- <item>
- <spacer name="horizontalSpacer_11">
- <property name="orientation">
- <enum>Qt::Horizontal</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Fixed</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>20</height>
- </size>
- </property>
- </spacer>
- </item>
- <item alignment="Qt::AlignVCenter">
- <widget class="QLabel" name="typeSpacerTop">
- <property name="minimumSize">
- <size>
- <width>1</width>
- <height>30</height>
- </size>
- </property>
- <property name="maximumSize">
- <size>
- <width>1</width>
- <height>30</height>
- </size>
- </property>
- <property name="styleSheet">
- <string notr="true">background-color:white;
-padding:0px;
-border:none;</string>
- </property>
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- <item>
- <spacer name="horizontalSpacer_12">
- <property name="orientation">
- <enum>Qt::Horizontal</enum>
- </property>
- <property name="sizeType">
- <enum>QSizePolicy::Fixed</enum>
- </property>
- <property name="sizeHint" stdset="0">
- <size>
- <width>20</width>
- <height>20</height>
- </size>
- </property>
- </spacer>
- </item>
- <item alignment="Qt::AlignTop">
- <widget class="QLabel" name="labelAmountTopzPiv">
- <property name="minimumSize">
- <size>
- <width>0</width>
- <height>36</height>
- </size>
- </property>
- <property name="text">
- <string notr="true">1,000 zPIV</string>
- </property>
- </widget>
- </item>
</layout>
</widget>
</item>
|
random-zebra
force-pushed
the
202004_GUI_remove_zPIV_controls
branch
from
6690da5 to
fc8f983
Compare
Author
|
good find @Fuzzbawls . Updated / squashed in fc8f98316099d90c51d1f2b8aad83b216d50714d |
Fuzzbawls
previously approved these changes
Jun 5, 2020
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK fc8f98316099d90c51d1f2b8aad83b216d50714d
random-zebra
force-pushed
the
202004_GUI_remove_zPIV_controls
branch
from
fc8f983 to
09973ef
Compare
Author
|
Rebased. |
furszy
approved these changes
Jun 10, 2020
random-zebra
added a commit
that referenced
this pull request
Jun 16, 2020
30618a6 WalletModel: remove unused zerocoin methods (furszy) Pull request description: #1549 dropped zerocoin support in the GUI, this is a follow up removing the now unused methods and signal connections from the wallet model . ACKs for top commit: random-zebra: utACK 30618a6 Fuzzbawls: ACK 30618a6 Tree-SHA512: eb82b12f277e9da7e03ae08ca6b7e5ec58adedb241b22558caf154b7f2120134cd2475a79f675c2e9b9eb395497a76818de97a53a04fb81836d41ba77383f847
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jun 24, 2020
Document the changes introduced in: - PIVX-Project#1549: Nuke zPIV from the GUI - PIVX-Project#1586: Minimum value for stake split threshold - PIVX-Project#1633: Bitcoin 0.12-0.14 serialization improvements - PIVX-Project#1645: Implement accurate memory accounting for mempool - PIVX-Project#1647: MemPool package tracking and limits - PIVX-Project#1650: Benchmarking Framework - PIVX-Project#1688: TopBar navigation (sync/peers)
random-zebra
added a commit
that referenced
this pull request
Jun 29, 2020
4819ee7 [Doc] Add/Update some release notes for 4.2 (random-zebra) Pull request description: Document the changes introduced in: - #1549: Nuke zPIV from the GUI - #1586: Minimum value for stake split threshold - #1633: Bitcoin 0.12-0.14 serialization improvements - #1645: Implement accurate memory accounting for mempool - #1647: MemPool package tracking and limits - #1650: Benchmarking Framework - #1688: TopBar navigation (sync/peers) ACKs for top commit: furszy: utACK 4819ee7 Fuzzbawls: ACK 4819ee7 Tree-SHA512: 62ad949ea26a2f877ef0b40ec86616cc8105f81e1fcd380c8162cd93af04a46f1093f878c0668408654f198a0059b240798b83af3bf1d5e6c1c1d8611276a325
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As anticipated, after 4.1, zPIV will be accessible only through the CLI/RPC interface and will be completely removed from the GUI.
Only mention left is in the staking charts (and tx records), for historical purpose.
EDIT: Closes #1628