SetMerkleBranch: remove unused code, remove cs_main lock requirement #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetMerkleBranch was the only call underneath SyncTransaction that required the cs_main lock.
|
Nice. Concept ACK |
Fuzzbawls
approved these changes
Apr 14, 2020
JSKitty
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetMerkleBranch's return value is no longer being used. Remove the unnecessary code part. Coming from upstream@9446.And removed the
cs_mainlock from CWallet::SyncTransaction that was previously needed do theSetMerkleBranchassert lock held.