[GUI] Back port latest MacOS dock icon handler. #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt `setWindowIcon()` does this work. Coming from btc@53bb6be3f8a50ee9e5c4d7e9155236152e7c4b7c
This moves the Dock icon click reaction code to the common place and allows some cleanup in obj_c code. According to the Apple's docs `class_replaceMethod` behaves as `class_addMethod`, if the method identified by name does not yet exist; or as `method_setImplementation`, if it does exist. Coming from btc@2464925e7be832d4926b6204169bbbc1646c6368
Qt `setAsDockMenu()` does this work. Coming from btc@6b1d2972bf9a40f97ba3a5c95831fd179b1054cf
Coming from btc@5796671e1dd8a2d0b1e750c2dce19a10af624095
Coming from btc@6fc21aca6d5e16c3ece104fec8e5b3df116893b4
Coming from btc@0bb33b5348dbddd65b88a7f00449c965562355d3
random-zebra
added
Bug
Build System
macOS
random-zebra
approved these changes
Apr 10, 2020
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK a60b7cc
Don't have an environment to test this with, but have verified that gitian builds are fine.
Fuzzbawls
approved these changes
Apr 13, 2020
random-zebra
added a commit
that referenced
this pull request
May 20, 2020
a41da9f [QT] fix opening *.conf/log files on macOS when there is no default app to open them. (furszy) Pull request description: Built on top of #1515, only last commit counts for this. When MacOS has no default app to open *.conf and *.log throws an error instead of try to open them with a text editor. This PR solves the issue. Coming from btc@[16044](bitcoin#16044) ACKs for top commit: random-zebra: utACK a41da9f Fuzzbawls: utACK a41da9f Tree-SHA512: 5316e3a501576ed240cff9db32526eba7456112b8ad3024e5095a924a1da27f5ad5033fb3a4c50df305d262362e66abdffe2d17ff942895893e9889750dc8bf8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
MacDockIconHandlerto latest upstream. Fixing #1512 .Back ported PRs:
gui: Add GUIUtil::bringToFront 14123:
qt: Replace objc_msgSend() function calls with the native Objective-C syntax 16720: