[Core] Reduce CBlockIndex RAM usage #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202004_chainIndex_round2
branch
4 times, most recently
from
bb048d2 to
30989eb
Compare
random-zebra
force-pushed
the
202004_chainIndex_round2
branch
2 times, most recently
from
85f2c0f to
adfcd45
Compare
furszy
reviewed
Apr 9, 2020
furszy
reviewed
Apr 9, 2020
furszy
reviewed
Apr 9, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Overall looking great 👌 .
Two more things:
What commented about the mapZerocoinSupply applies to the nMoneySupply global object too.
And would be nice to have a reorg functional test verifying that the nMoneySupply and the mapZerocoinSupply gets disconnected/updated properly . We could add it to the mining_pos_reorg.py test.
Author
|
Updated as per feedback. |
random-zebra
changed the title
random-zebra
force-pushed
the
202004_chainIndex_round2
branch
from
851b66a to
d565a73
Compare
on height_ZC_RecalcAccumulators, without a supply checkpoint. Use wrapped serials check instead.
GetMasternodePayment is never called during IBD, thus we don't need historical values. Make it return fixed 3 PIV amount.
random-zebra
force-pushed
the
202004_chainIndex_round2
branch
from
d565a73 to
e4fdba3
Compare
random-zebra
force-pushed
the
202004_chainIndex_round2
branch
from
e4fdba3 to
2b31bf4
Compare
Collaborator
|
So far, so good |
furszy
approved these changes
Apr 10, 2020
Fuzzbawls
approved these changes
Apr 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the work started in #1338 and bumps the version to
4.0.99.2.It gives a dramatic improvement in memory usage.
On mainnet synced up to block 2281117, it takes ~926 Mb in total (a 59% reduction over the 2.261 Gb of
v4.0.99.1, and 64% overall reduction over the 2.570 Gb ofv4.0.2).Changes:
mapZerocoinSupplyandmoneySupplyare removed from the block index serialization and replaced with a single cached map/value updated inConnectBlock/DisconnectBlockand databased independently.To avoid reindex on upgrade, a utility class
CLegacyBlockIndexis introduced, in order to marshall old (removed) block index members directly from disk.