Skip to content

[Net] Fix resource leak in ReadBinaryFile #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
random-zebra merged 1 commit into from
Apr 4, 2020
Merged

[Net] Fix resource leak in ReadBinaryFile #1484

random-zebra merged 1 commit into from
Apr 4, 2020

Conversation

@furszy
Copy link

@furszy furszy commented Apr 2, 2020 •
edited
Loading

Straightforward fix. Coming from upstream 10587

Potential file descriptor leak introduced in commit 0b6f40d via PR #10408 
(submitted 2017-05-16, merged 2017-05-18).

@furszy furszy self-assigned this Apr 2, 2020
@Fuzzbawls Fuzzbawls added the P2P label Apr 4, 2020
@Fuzzbawls Fuzzbawls added this to the 4.1.0 milestone Apr 4, 2020
Fuzzbawls
Fuzzbawls approved these changes Apr 4, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9c922b

random-zebra
random-zebra approved these changes Apr 4, 2020
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a9c922b and merging...

@random-zebra random-zebra merged commit 0a4072e into PIVX-Project:master Apr 4, 2020
JSKitty pushed a commit to ZENZO-Ecosystem/ZENZO-Core that referenced this pull request Apr 14, 2020
Backport PIVX-Project#1484 | Fix resource leak in ReadBinaryFile
ad61864
@lyricidal lyricidal mentioned this pull request Oct 18, 2022
Merged
@furszy furszy deleted the 2020_torcontrol_fclose branch November 29, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

P2P Upstream

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@furszy @Fuzzbawls @random-zebra @practicalswift