Skip to content

[Tests] Remove non-determinism which is breaking net_tests #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furszy merged 1 commit into from
Mar 23, 2020
Merged

[Tests] Remove non-determinism which is breaking net_tests #1442

furszy merged 1 commit into from
Mar 23, 2020

Conversation

@random-zebra
Copy link

@random-zebra random-zebra commented Mar 20, 2020 •
edited
Loading

from bitcoin#8070

If addrmanUncorrupted does not have the same nKey every time it will map addrs to different bucket positions and occasionally cause a collision between two addrs, breaking the test.

@random-zebra random-zebra added this to the 4.1.0 milestone Mar 20, 2020
@random-zebra random-zebra self-assigned this Mar 20, 2020
Fuzzbawls
Fuzzbawls approved these changes Mar 21, 2020
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aa66144

furszy
furszy approved these changes Mar 23, 2020
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK aa66144 and merging

@furszy furszy merged commit a5288ec into PIVX-Project:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@furszy furszy furszy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@random-zebra random-zebra

Labels

Tests Upstream

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@random-zebra @furszy @Fuzzbawls