[GUI] Automatic wallet backup after upgrade to HD #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
2020_upgrade_backup
branch
from
65cc11b to
53cfbee
Compare
Author
|
Rebased, now that #1387 is merged. |
furszy
approved these changes
Mar 23, 2020
Fuzzbawls
approved these changes
Mar 23, 2020
Author
|
merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
Offer the option to directly backup the wallet after upgrade-to-HD (and successive re-lock) is completed.
The message on the initial dialog is changed (from "Note that you will need to MAKE A NEW BACKUP.."):
If the user clicks "OK", and the wallet is locked, the unlock dialog is directly shown (as per #1387)
After the upgrade, the client directly presents this dialog:
If the user clicks "OK", then the open-file dialog is presented, so the user can select the filename for the backup file and click "Save" completing the flow.
If the user clicks "CANCEL" (or dismisses the open-file dialog later), a snackbar popup warns the user, telling to remember to backup asap.