[GUI] Upgrade to HD wallet functionality. #1405
Conversation
|
needs rebase now that #1399 has been merged |
furszy
force-pushed
the
2020_gui_upgrade_wallet
branch
from
a457dbd to
aa6e3d1
Compare
furszy
force-pushed
the
2020_gui_upgrade_wallet
branch
from
aa6e3d1 to
42ed283
Compare
|
Done, PR rebased. |
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
styling changes mostly, but some observations:
-
from the release notes: "A dialog will appear on every wallet startup notifying you that you are running a pre-HD wallet and letting you upgrade it from there." doesn't look like any such dialog notice is implemented just yet, but I do see the expandable button allowing HD upgrade.
-
when using the UI to upgrade to HD wallet, maybe we should provide a UI dialog notice confirming the upgrade was successful?
-
Post-upgrade, the HD expandable button remains until wallet restart
|
PR updated. Answering the observations:
And added the jump lines to the method brackets. |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
This looks good to me.
Only two considerations:
-
10 seconds of delay before showing the update dialog after startup seems "weird" to me (it basically shows up when you already started to perform some operation, e.g. sending or whatever). I would make it just 2 or 3 seconds max.
-
Clicking accept on the upgrade dialog (with locked wallet) presents another dialog which says to unlock and how to proceed afterwards.
This would be nicer if the unlock dialog were presented instead, and the user could directly insert his password (instead of clicking close --> unlocking --> clicking the HD button to upgrade).
This can be achieved rebasing this PR on top of #1387.
Or alternatively we can merge this one, and add this flow to #1387 later.
|
The idea behind the 10 seconds delay was to have the wallet running properly before the notification gets launched (sometimes the first window show is not so smooth -- varies over the different OS and machine resources --). But sure, we can decrease it to possibly 4 seconds. And about the unlock context point, agree. Would merge this and create a new PR once #1387 gets merged. |
furszy
force-pushed
the
2020_gui_upgrade_wallet
branch
from
90a0b29 to
0e969f1
Compare
3 participants
This was built on top of #1399.
Essentially connecting the HD wallet upgrade to the GUI as it was defined in the release-notes in #1327.