[RPC] Upgrade to HD wallet. #1399
Conversation
furszy
force-pushed
the
2020_rpc_upgrade_wallet
branch
2 times, most recently
from
835f948 to
9c56e03
Compare
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
Mostly minor changes, otherwise looking good
furszy
force-pushed
the
2020_rpc_upgrade_wallet
branch
from
9c56e03 to
23fd758
Compare
|
Done, comments tackled. |
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
Functionally done and good. two log output nits in the functional test that i missed last night.
Otherwise, this is an ACK
test/functional/wallet_upgrade.py
Outdated
There was a problem hiding this comment.
nit: to avoid confusion, i think this should be changed to something like
self.log.info("## Testing the upgrade via RPC now, stopping the node...")rationale: "runtime" (or "at runtime") is typically used to describe something that happens automatically when the wallet is started. That would be a good term to use for the -upgradewallet startup flag, but not for the upgradewallet RPC command, which requires post-startup action.
There was a problem hiding this comment.
"at startup" is something that happens automatically when the wallet is started, "at runtime" denotes an action that is performed when the software is running at any time (the "runtime" concept applies to actions that occurs during the software execution).
Side from that, agree that we can just put "upgrade via RPC now" and done.
test/functional/wallet_upgrade.py
Outdated
There was a problem hiding this comment.
nit: per above, would probably change this to something like
self.log.info("Upgrade via RPC completed, all good :)")
furszy
force-pushed
the
2020_rpc_upgrade_wallet
branch
from
23fd758 to
9fcc576
Compare
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Code looks good. A couple of styling nits.
Upgrade wallet functionality to bump the wallet features to the latest supported version. Upgrading from non-HD to HD wallet.
furszy
force-pushed
the
2020_rpc_upgrade_wallet
branch
from
9fcc576 to
c859f0c
Compare
|
Updated following the comments. |
0e969f1 [GUI] Launch upgrade wallet dialog at the wallet's startup. (furszy) 7c468ce [Trivial] Method brackets jump lines. (furszy) 42ed283 [GUI] Upgrade wallet to HD functionality connected. (furszy) c29d34e [GUI] isHDEnabled & upgradeWallet methods created. (furszy) Pull request description: This was built on top of PIVX-Project#1399. Essentially connecting the HD wallet upgrade to the GUI as it was defined in the release-notes in PIVX-Project#1327. ACKs for top commit: random-zebra: ACK 0e969f1 Fuzzbawls: ACK 0e969f1 Tree-SHA512: 8d6ee4a5c53b2bead2303b8fd241ef7404ee5cb62599118e3328073b7ce6b5b63d7555bb5d26e5d3b266514476d81d1deb3f42c738216ea788c87babc019cf88
3 participants
The rationality behind this work is that locked wallets, as them are encrypted, are not able to upgrade to HD wallet. The keystore and thereby keys are not available to perform any action at initialization time.
This PR solves it adding a new JSON-RPC command
upgradewalletto be able to upgrade the wallet at runtime, requesting the wallet passphrase if it's needed.A functional test verifying the new command was included inside the
wallet_upgrade.pytest.