[GUI] Add Unlock/Relock context flow #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
added
Feature Request
GUI
Wallet
Needs Release Notes
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
33d651e to
39e5562
Compare
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
39e5562 to
153088d
Compare
Author
|
Styling consistency changes have been grouped in the first commit (and expanded to include all files edited). |
random-zebra
removed
the
Needs Release Notes
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
8bbc2dc to
c7eb49a
Compare
Author
|
Rebased. |
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
c7eb49a to
3f12546
Compare
Author
|
Rebased |
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
3f12546 to
a195f30
Compare
Author
|
Rebased, and added unlock context for "upgrade to HD" flow. |
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
a195f30 to
112b541
Compare
1 task
furszy
previously approved these changes
Mar 21, 2020
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
One minor thing, would be better if we squash 3dcf0ee4 and ae620312 inside the UnlockContext commit as those are changes over code that was introduced there.
Side from that, ACK 112b541 .
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
112b541 to
498da1d
Compare
Author
|
Commits squashed as per request. |
|
Needs rebase (we should merge this to not continue rebasing it anymore, it's ready to go for me). |
askpassphrasedialog is used instead
Connect the signal emitted by WalletModel::requestUnlock to the TopBar, in order to present the unlock-wallet dialog, before creating the UnlockContext. The wallet will then restore its previous state (Unlocked or UnlockedForStaking) upon destruction of the UnlockContext object.
PWidget::verifyWalletUnlocked replaced with the UnlockContext. Add flows: - Create New Receive Address - Create New Payment Request - Create Masternode Controller - Create Cold Staking Address - Send Cold Stake Delegation - Add multisend recipient
random-zebra
force-pushed
the
2020_UnlockContext
branch
from
498da1d to
aa7ff86
Compare
Author
|
Rebased... again. |
Fuzzbawls
approved these changes
Mar 23, 2020
random-zebra
added a commit
that referenced
this pull request
Mar 23, 2020
53cfbee [GUI] Automatic wallet backup after upgrade to HD (random-zebra) Pull request description: Based on - [x] #1387 Offer the option to directly backup the wallet after upgrade-to-HD (and successive re-lock) is completed. The message on the initial dialog is changed (from "Note that you will need to MAKE A NEW BACKUP.."):  If the user clicks "OK", and the wallet is locked, the unlock dialog is directly shown (as per #1387)  After the upgrade, the client directly presents this dialog:  If the user clicks "OK", then the open-file dialog is presented, so the user can select the filename for the backup file and click "Save" completing the flow. If the user clicks "CANCEL" (or dismisses the open-file dialog later), a snackbar popup warns the user, telling to remember to backup asap. ACKs for top commit: furszy: Tested ACK 53cfbee. Fuzzbawls: ACK 53cfbee Tree-SHA512: 80fbcdb4d9805d75db98a0f394840f734314e6d249539997f1948cd7775ac2a81239b762386b7770c6ca4b8a2c38acdf1d5ae7ee7f07591bfdfc7dd4ee39cfc2
JSKitty
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Apr 16, 2020
Style changes will be left for a later cleanup PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
UnlockContextclass and connect it where needed.Now, once an action requires the wallet to be fully unlocked, the askpassphrase dialog is presented to the user (if the status is "Locked" or "UnlockedForStaking"). This way, the password can be entered directly, and the operation can resume without needing additional clicks by the user.
The previous locking status is restored when the action completes.
Interested flows:
Also
Closes #553
Closes #1035
And maybe #1152 becomes not needed now.