[Refactor] move nReserveBalance from main to wallet #1366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nReserveBalance is set (and checked) during init or via RPC reservebalance
furszy
approved these changes
Mar 3, 2020
|
we should close this, #1373 is removing it anyway. |
Author
|
Yep. As stated in the PR description there, if it is conceptually accepted, will close this one. |
|
by-passed that last sentence in the other PR description and went directly into the code, sorry. |
Author
|
Alright, closing in favor of #1373 |
random-zebra
added a commit
that referenced
this pull request
Mar 11, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close #1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close PIVX-Project#1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close PIVX-Project#1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
akshaynexus
pushed a commit
to ZENZO-Ecosystem/ZENZO-Core
that referenced
this pull request
Mar 15, 2020
721b109 [Doc] Remove reservebalance (random-zebra) a4627c6 [Core] remove nReserveBalance ext var (and -reservebalance option) (random-zebra) d481e77 [Wallet] StakeableCoins: remove reserve balance check (random-zebra) 35f0122 [RPC] Remove reservebalance RPC method (random-zebra) Pull request description: `reservebalance` is a leftover from peercoin code which was probably never used. Currently it is also broken: the final loop in `CWallet::StakeableCoins` is useless (updating an un-used local variable `nAmountSelected` and not removing any utxo from the vector of stakeable coins). Failing to see a valid use-case for it (not already provided by the stake-split threshold), I propose to just remove it. This also makes the call to `GetStakingBalance` from `StakeableCoins` not needed (thus one less loop over mapWallet txes). If this is accepted (at least conceptually) will update the release notes, and close PIVX-Project#1366 (superseded by this one). ACKs for top commit: furszy: utACK 721b109. Fuzzbawls: utACK 721b109 Tree-SHA512: 972749a7181dbc373b1bc64a6ceae357fb478f49cefe8f4c2271bf8f3c2a8088d69e46a8687ed007eab8287a124df0e266ad626d01bc22a11742a3b9b8a00284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward.
Also remove an extra check/parsing in
CWallet::StakeableCoins.